Re: Review Request 38882: FALCON-1495: In instance status list, show all runs for instances when requested by user

[Ajay Yadava <aj...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38882/#review112606
-----------------------------------------------------------



client/src/main/java/org/apache/falcon/client/FalconClient.java (line 495)
<https://reviews.apache.org/r/38882/#comment173111>

    Instead of using sendInstanceRequest method and making changes to all other API calls as well, it is better to create another method and use that for this change.



docs/src/site/twiki/FalconCLI.twiki (line 285)
<https://reviews.apache.org/r/38882/#comment173112>

    This should go to cli/ListInstance.twiki



docs/src/site/twiki/FalconCLI.twiki (line 291)
<https://reviews.apache.org/r/38882/#comment173113>

    Please attach an example with this option and result (in ListInstance.twiki)



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 685)
<https://reviews.apache.org/r/38882/#comment173115>

    This condition can be moved above try and I believe then we can avoid repeating it 3 times.



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 847)
<https://reviews.apache.org/r/38882/#comment173114>

    Instead of accepting a list and updating it, return the list as a result of this method.



oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java (line 855)
<https://reviews.apache.org/r/38882/#comment173243>

    Use StringUtils.isNotBlank



scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java (line 343)
<https://reviews.apache.org/r/38882/#comment173245>

    Please remove todo and raise a JIRA if required.


- Ajay Yadava


On Dec. 31, 2015, 5:23 a.m., Narayan Periwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38882/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2015, 5:23 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-1495
>     https://issues.apache.org/jira/browse/FALCON-1495
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Most of the times , when there are failures in the pipelines, retries run and the workflows might have got succeeded in sub sequential retry. But for end user to figure out why it has failed initially might be useful to understand for failures handling and SLA misses.
> 
> As of now to figure out the same, its a tedious task to get such information by either going through oozie DB/logs or via the logs backed up in hdfs by the falcon postprocessing(which is 100% reliable as in few cases, falcon post processing might fail or for some reason if it couldn't back up the logs).
> 
> In either case, Falcon should abstract the oozie client layer to be used by end user, and support all runs status to end user.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/falcon/cli/FalconInstanceCLI.java bfb1d65 
>   client/src/main/java/org/apache/falcon/client/AbstractFalconClient.java e59af24 
>   client/src/main/java/org/apache/falcon/client/FalconClient.java 4a773c6 
>   common/src/main/java/org/apache/falcon/workflow/engine/AbstractWorkflowEngine.java b53efe6 
>   docs/src/site/twiki/FalconCLI.twiki 26e6b33 
>   docs/src/site/twiki/restapi/InstanceList.twiki 229d6f9 
>   oozie/src/main/java/org/apache/falcon/workflow/engine/OozieWorkflowEngine.java b486357 
>   prism/src/main/java/org/apache/falcon/resource/AbstractInstanceManager.java d50d111 
>   prism/src/main/java/org/apache/falcon/resource/AbstractSchedulableEntityManager.java 88131f3 
>   prism/src/main/java/org/apache/falcon/resource/proxy/InstanceManagerProxy.java 801bd10 
>   scheduler/src/main/java/org/apache/falcon/workflow/engine/FalconWorkflowEngine.java bceab72 
>   unit/src/main/java/org/apache/falcon/unit/FalconUnitClient.java 13375ef 
>   unit/src/main/java/org/apache/falcon/unit/LocalInstanceManager.java 148cbf7 
>   unit/src/test/java/org/apache/falcon/unit/FalconUnitTestBase.java 382e0c9 
>   webapp/src/main/java/org/apache/falcon/resource/InstanceManager.java 76c66f3 
>   webapp/src/test/java/org/apache/falcon/resource/InstanceSchedulerManagerJerseyIT.java 1523b76 
>   webapp/src/test/java/org/apache/falcon/resource/ProcessInstanceManagerIT.java 755efa3 
> 
> Diff: https://reviews.apache.org/r/38882/diff/
> 
> 
> Testing
> -------
> 
> Done.
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>