[jira] [Commented] (YARN-4105) Capacity Scheduler headroom for DRF is wrong

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14726782#comment-14726782 ] 

Hadoop QA commented on YARN-4105:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch |  17m  0s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 47s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 58s | There were no new javadoc warning messages. |
| {color:green}+1{color} | release audit |   0m 24s | The applied patch does not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 51s | There were no new checkstyle issues. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 10  line(s) that end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install |   1m 26s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 29s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests |  54m 17s | Tests failed in hadoop-yarn-server-resourcemanager. |
| | |  93m 49s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12753664/YARN-4105.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 00804e2 |
| Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/8963/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-resourcemanager.html |
| whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/8963/artifact/patchprocess/whitespace.txt |
| hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8963/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8963/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8963/console |


This message was automatically generated.

> Capacity Scheduler headroom for DRF is wrong
> --------------------------------------------
>
>                 Key: YARN-4105
>                 URL: https://issues.apache.org/jira/browse/YARN-4105
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: YARN-4105.patch
>
>
> relate to the problem discussed in YARN-1857. But the min method is flawed when we are using DRC. Have run into a real scenario in production where queueCapacity: <memory:1056256, vCores:3750>, qconsumed: <memory:1054720, vCores:361>, consumed: <memory:125952, vCores:170> limit: <memory:214016, vCores:755>.  headRoom calculation returns 88064 where there is only 1536 left in the queue because DRC effectively compare by vcores. It then caused deadlock because RMcontainer allocator thought there is still space for mapper and won't preempt a reducer in a full queue to schedule a mapper. Propose fix with componentwiseMin. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)