You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/05/07 14:47:41 UTC

[GitHub] [qpid-dispatch] ChugR opened a new pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers

ChugR opened a new pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197


   There is no on_modified event in proton python MessagingHandler.
   Proton conflates Delivery.MODIFIED and Delivery.RELEASED state handling
   and delivers both states in the on_released handler.
   
   This patch makes the dispatch handler model precisely reflect the
   proton handler model.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers

Posted by GitBox <gi...@apache.org>.
jiridanek commented on a change in pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r628463490



##########
File path: tests/system_test.py
##########
@@ -1107,15 +1107,10 @@ def on_accepted(self, event):
         event.delivery.settle()
 
     def on_released(self, event):
-        # for some reason Proton 'helpfully' calls on_released even though the
-        # delivery state is actually MODIFIED
         if event.delivery.remote_state == Delivery.MODIFIED:
-            return self.on_modified(event)

Review comment:
       This makes the handlers work the way they "should've been" done in Proton, imo. I thought that it was a reasonable improved thing to do. But ok, the Proton orthodoxy prevails.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] ChugR commented on pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers

Posted by GitBox <gi...@apache.org>.
ChugR commented on pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#issuecomment-885695863


   The handling in system_test makes a nice on_modified callback for dispatch self tests. Leave it as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers

Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r675623583



##########
File path: tests/system_test.py
##########
@@ -1107,15 +1107,10 @@ def on_accepted(self, event):
         event.delivery.settle()
 
     def on_released(self, event):
-        # for some reason Proton 'helpfully' calls on_released even though the
-        # delivery state is actually MODIFIED
         if event.delivery.remote_state == Delivery.MODIFIED:
-            return self.on_modified(event)

Review comment:
       You know what, I agree with you. Leave it as is.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org

[GitHub] [qpid-dispatch] ChugR closed pull request #1197: DISPATCH-1595: Remove all python test on_modified event handlers

Posted by GitBox <gi...@apache.org>.
ChugR closed pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org