[jira] [Commented] (TEZ-2511) Add exitCode to diagnostics when container fails

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568703#comment-14568703 ] 

TezQA commented on TEZ-2511:
----------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12736768/TEZ-2511-1.patch
  against master revision 4c48283.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The following test timeouts occurred in :
 org.apache.tez.dag.app.dag.impl.TestVertexImpl

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/778//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/778//console

This message is automatically generated.

> Add exitCode to diagnostics when container fails
> ------------------------------------------------
>
>                 Key: TEZ-2511
>                 URL: https://issues.apache.org/jira/browse/TEZ-2511
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2511-1.patch
>
>
> Currently we only identify the container failure cause for PREEMPTED / DISKS_FAILED, that means except for these 2 cases, there would be no clear diagnostic message for other cases. 
> {code}
>       String message = "Container completed. ";
>       TaskAttemptTerminationCause errCause = TaskAttemptTerminationCause.CONTAINER_EXITED;
>       int exitStatus = containerStatus.getExitStatus();
>       if (exitStatus == ContainerExitStatus.PREEMPTED) {
>         message = "Container preempted externally. ";
>         errCause = TaskAttemptTerminationCause.EXTERNAL_PREEMPTION;
>       } else if (exitStatus == ContainerExitStatus.DISKS_FAILED) {
>         message = "Container disk failed. ";
>         errCause = TaskAttemptTerminationCause.NODE_DISK_ERROR;
>       } else if (exitStatus != ContainerExitStatus.SUCCESS){
>         message = "Container failed. ";
>       }
>       if (containerStatus.getDiagnostics() != null) {
>         message += containerStatus.getDiagnostics();
>       }
>       sendEvent(new AMContainerEventCompleted(amContainer.getContainerId(), exitStatus, message, errCause));
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)