You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "MaWenlong1 (GitHub)" <gi...@apache.org> on 2019/03/26 17:03:19 UTC
[GitHub] [incubator-dubbo] MaWenlong1 opened pull request #3742:
[Dubbo-3741]Remove extra tags
## What is the purpose of the change
Remove extra tags #3741
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3742 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3742:
[Dubbo-3741]Remove extra tags
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
LGTM
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3742 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3742:
[Dubbo-3741]Remove extra tags
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3742?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@fb0fd60`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3742?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3742 +/- ##
========================================
Coverage ? 63.5%
Complexity ? 71
========================================
Files ? 704
Lines ? 31069
Branches ? 5022
========================================
Hits ? 19731
Misses ? 9057
Partials ? 2281
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3742?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3742?src=pr&el=footer). Last update [fb0fd60...f52869f](https://codecov.io/gh/apache/incubator-dubbo/pull/3742?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3742 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM closed pull request #3742:
[Dubbo-3741]Remove extra tags
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
[ pull request closed by CrazyHZM ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3742 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org