You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/28 16:00:20 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #1145: usbhost: adds a driver for the FTDI FT232R USB to serial converter

patacongo commented on pull request #1145:
URL: https://github.com/apache/incubator-nuttx/pull/1145#issuecomment-635438863


   There are a few style problems that need to be fixed before we can do the merge.  There is one in your new files?
   
   drivers/usbhost/usbhost_ft232r.c:831:26: error: Multiple data definitions
   
   But lots in the existing file:  include/nuttx/usb/usbhost.h.  Most of those are probably not yours, but we ask people to clean up style-related problems in an all modified files.  Think of it as your way to contribute to the quality of the OS ;)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org