You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jan Vermeulen <ja...@isencia.com> on 2007/08/28 18:58:22 UTC
WicketServlet no longer sets application on current thread
The last changes made to WicketFilter (move Application.set(webApplication)
from doGet() to doFilter()) have a side effect: if working with
WicketServlet (due to OSGI), the application is no longer set on the current
thread, because it was moved to doFilter().
Can this be fixed ?
Jan.
--
View this message in context: http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
Sent from the Wicket - Dev mailing list archive at Nabble.com.
Re: WicketServlet no longer sets application on current thread
Posted by Evan Chooly <ev...@gmail.com>.
I was seeing that with the snapshots and moved to beta3 and can confirm it
is, indeed, fixed.
On 8/29/07, Johan Compagner <jc...@gmail.com> wrote:
>
> it should be fixed now (lastmodified request/application thread local sets
> and that maybe in combination with a WicketServlet)
>
> On 8/29/07, Johan Compagner <jc...@gmail.com> wrote:
> >
> > hmm that also doesn't fix it completely
> >
> > i am also diving into this, it is pretty complex now when you also take
> > the wicket servlet into account :(
> >
> > On 8/29/07, Eelco Hillenius <ee...@gmail.com> wrote:
> > >
> > > I think that fixed it.
> > >
> > > Eelco
> > >
> > > On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
> > > >
> > > > I'll do that.
> > > >
> > > > Jan.
> > > >
> > > > Matej Knopp-2 wrote:
> > > > >
> > > > > That's not good. Can you please create a jira issue for this?
> > > > >
> > > > > -Matej
> > > > >
> > > > > On 8/28/07, Jan Vermeulen < jan.vermeulen@isencia.com> wrote:
> > > > >>
> > > > >>
> > > > >> The last changes made to WicketFilter (move Application.set
> > > > >> (webApplication)
> > > > >> from doGet() to doFilter()) have a side effect: if working with
> > > > >> WicketServlet (due to OSGI), the application is no longer set on
> > > the
> > > > >> current
> > > > >> thread, because it was moved to doFilter().
> > > > >>
> > > > >> Can this be fixed ?
> > > > >>
> > > > >> Jan.
> > > > >> --
> > > > >> View this message in context:
> > > > >>
> > >
> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
> > > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com.
> > > > >>
> > > > >>
> > > > >
> > > > >
> > > >
> > > > --
> > > > View this message in context:
> > >
> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12372441
> > > > Sent from the Wicket - Dev mailing list archive at Nabble.com.
> > > >
> > > >
> > >
> >
> >
>
Re: WicketServlet no longer sets application on current thread
Posted by Johan Compagner <jc...@gmail.com>.
it should be fixed now (lastmodified request/application thread local sets
and that maybe in combination with a WicketServlet)
On 8/29/07, Johan Compagner <jc...@gmail.com> wrote:
>
> hmm that also doesn't fix it completely
>
> i am also diving into this, it is pretty complex now when you also take
> the wicket servlet into account :(
>
> On 8/29/07, Eelco Hillenius <ee...@gmail.com> wrote:
> >
> > I think that fixed it.
> >
> > Eelco
> >
> > On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
> > >
> > > I'll do that.
> > >
> > > Jan.
> > >
> > > Matej Knopp-2 wrote:
> > > >
> > > > That's not good. Can you please create a jira issue for this?
> > > >
> > > > -Matej
> > > >
> > > > On 8/28/07, Jan Vermeulen < jan.vermeulen@isencia.com> wrote:
> > > >>
> > > >>
> > > >> The last changes made to WicketFilter (move Application.set
> > > >> (webApplication)
> > > >> from doGet() to doFilter()) have a side effect: if working with
> > > >> WicketServlet (due to OSGI), the application is no longer set on
> > the
> > > >> current
> > > >> thread, because it was moved to doFilter().
> > > >>
> > > >> Can this be fixed ?
> > > >>
> > > >> Jan.
> > > >> --
> > > >> View this message in context:
> > > >>
> > http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
> > > >> Sent from the Wicket - Dev mailing list archive at Nabble.com.
> > > >>
> > > >>
> > > >
> > > >
> > >
> > > --
> > > View this message in context:
> > http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12372441
> > > Sent from the Wicket - Dev mailing list archive at Nabble.com.
> > >
> > >
> >
>
>
Re: WicketServlet no longer sets application on current thread
Posted by Johan Compagner <jc...@gmail.com>.
hmm that also doesn't fix it completely
i am also diving into this, it is pretty complex now when you also take the
wicket servlet into account :(
On 8/29/07, Eelco Hillenius <ee...@gmail.com> wrote:
>
> I think that fixed it.
>
> Eelco
>
> On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
> >
> > I'll do that.
> >
> > Jan.
> >
> > Matej Knopp-2 wrote:
> > >
> > > That's not good. Can you please create a jira issue for this?
> > >
> > > -Matej
> > >
> > > On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
> > >>
> > >>
> > >> The last changes made to WicketFilter (move Application.set
> > >> (webApplication)
> > >> from doGet() to doFilter()) have a side effect: if working with
> > >> WicketServlet (due to OSGI), the application is no longer set on the
> > >> current
> > >> thread, because it was moved to doFilter().
> > >>
> > >> Can this be fixed ?
> > >>
> > >> Jan.
> > >> --
> > >> View this message in context:
> > >>
> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
> > >> Sent from the Wicket - Dev mailing list archive at Nabble.com.
> > >>
> > >>
> > >
> > >
> >
> > --
> > View this message in context:
> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12372441
> > Sent from the Wicket - Dev mailing list archive at Nabble.com.
> >
> >
>
Re: WicketServlet no longer sets application on current thread
Posted by Eelco Hillenius <ee...@gmail.com>.
I think that fixed it.
Eelco
On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
>
> I'll do that.
>
> Jan.
>
> Matej Knopp-2 wrote:
> >
> > That's not good. Can you please create a jira issue for this?
> >
> > -Matej
> >
> > On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
> >>
> >>
> >> The last changes made to WicketFilter (move Application.set
> >> (webApplication)
> >> from doGet() to doFilter()) have a side effect: if working with
> >> WicketServlet (due to OSGI), the application is no longer set on the
> >> current
> >> thread, because it was moved to doFilter().
> >>
> >> Can this be fixed ?
> >>
> >> Jan.
> >> --
> >> View this message in context:
> >> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
> >> Sent from the Wicket - Dev mailing list archive at Nabble.com.
> >>
> >>
> >
> >
>
> --
> View this message in context: http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12372441
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>
Re: WicketServlet no longer sets application on current thread
Posted by Jan Vermeulen <ja...@isencia.com>.
I'll do that.
Jan.
Matej Knopp-2 wrote:
>
> That's not good. Can you please create a jira issue for this?
>
> -Matej
>
> On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
>>
>>
>> The last changes made to WicketFilter (move Application.set
>> (webApplication)
>> from doGet() to doFilter()) have a side effect: if working with
>> WicketServlet (due to OSGI), the application is no longer set on the
>> current
>> thread, because it was moved to doFilter().
>>
>> Can this be fixed ?
>>
>> Jan.
>> --
>> View this message in context:
>> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
>> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>>
>>
>
>
--
View this message in context: http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12372441
Sent from the Wicket - Dev mailing list archive at Nabble.com.
Re: WicketServlet no longer sets application on current thread
Posted by Matej Knopp <ma...@gmail.com>.
That's not good. Can you please create a jira issue for this?
-Matej
On 8/28/07, Jan Vermeulen <ja...@isencia.com> wrote:
>
>
> The last changes made to WicketFilter (move Application.set
> (webApplication)
> from doGet() to doFilter()) have a side effect: if working with
> WicketServlet (due to OSGI), the application is no longer set on the
> current
> thread, because it was moved to doFilter().
>
> Can this be fixed ?
>
> Jan.
> --
> View this message in context:
> http://www.nabble.com/WicketServlet-no-longer-sets-application-on-current-thread-tf4342913.html#a12371848
> Sent from the Wicket - Dev mailing list archive at Nabble.com.
>
>