[GitHub] [pulsar] codelipenghui commented on a change in pull request #8493: [Transaction] Register transaction metadata before send or ack messages

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #8493:
URL: https://github.com/apache/pulsar/pull/8493#discussion_r520369305



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBase.java
##########
@@ -473,30 +473,34 @@ public void negativeAcknowledge(Message<?> message) {
     protected CompletableFuture<Void> doAcknowledgeWithTxn(List<MessageId> messageIdList, AckType ackType,
                                                            Map<String,Long> properties,
                                                            TransactionImpl txn) {
-        CompletableFuture<Void> ackFuture = doAcknowledge(messageIdList, ackType, properties, txn);
+        CompletableFuture<Void> ackFuture;
         if (txn != null) {
-            txn.registerAckedTopic(getTopic(), subscription);
-            return txn.registerAckOp(ackFuture);
+            ackFuture = txn.registerAckedTopic(getTopic(), subscription)
+                    .thenCompose(ignored -> doAcknowledge(messageIdList, ackType, properties, txn));
+            txn.registerAckOp(ackFuture);

Review comment:
       Should we handle the exception here? If the metadata register failed, we can't send message or ack




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org