You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/03/14 08:30:39 UTC
[GitHub] [rocketmq] cserwen opened a new pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
cserwen opened a new pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504
**Make sure set the target branch to `develop`**
## What is the purpose of the change
#3503
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou merged pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
odbozhou merged pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
cserwen commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1066502239
@RongtongJin Why this pr was closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1066533401
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`5.0.0-beta@4506f34`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 5.0.0-beta #3504 +/- ##
=============================================
Coverage ? 45.45%
Complexity ? 5624
=============================================
Files ? 722
Lines ? 50616
Branches ? 6935
=============================================
Hits ? 23005
Misses ? 24645
Partials ? 2966
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4506f34...7191932](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
cserwen commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1066520240
> > @RongtongJin Why this pr was closed?
>
> Sorry, because the 5.0-alpha distribution has a rollback, I pushed a new 5.0-beta branch (deleted the original branch), resulting in the automatic close of PR.
OK, I got it.:smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
cserwen commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1061669969
@duhenglucky Can you help me to review this pr?:blush:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin closed pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
RongtongJin closed pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
lizhiboo commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1046509276
BTW, getMessageTmpResult == null contains two cases, such as defaultMessageStore is shutdown and defaultMessageStore is not readable. The detail causes of these two cases is lost. We can improve it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-972552414
[](https://coveralls.io/builds/47321911)
Coverage increased (+0.2%) to 49.65% when pulling **7191932a1d816aedf75e7fe99e2fbdc731b75b89 on cserwen:bugfix_offset_0** into **56d2087c5b0a1699477bc9e7e44c1be0442cbde6 on apache:5.0.0-beta**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1066509407
@cserwen I reopen the pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] odbozhou merged pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
odbozhou merged pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-972552414
[](https://coveralls.io/builds/44359057)
Coverage decreased (-0.03%) to 53.446% when pulling **7191932a1d816aedf75e7fe99e2fbdc731b75b89 on cserwen:bugfix_offset_0** into **4506f34e24714ec4d6ac37babd8f096632fd6b1c on apache:5.0.0-alpha**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1066509059
> @RongtongJin Why this pr was closed?
Sorry, because the 5.0-alpha distribution has a rollback, I pushed a new 5.0-beta branch (deleted the original branch), resulting in the automatic close of PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
cserwen commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1046556259
> BTW, getMessageTmpResult == null contains two cases, such as defaultMessageStore is shutdown and defaultMessageStore is not readable. The detail causes of these two cases is lost. We can improve it in the future.
Yes! I agree with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] cserwen commented on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
cserwen commented on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1012832734
@odbozhou Can you help me to review this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3504: [ISSUE #3503] fix the consumeOffset will be set as 0 when getMessage returns null
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3504:
URL: https://github.com/apache/rocketmq/pull/3504#issuecomment-1066533401
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`5.0.0-beta@4506f34`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 5.0.0-beta #3504 +/- ##
=============================================
Coverage ? 45.50%
Complexity ? 5631
=============================================
Files ? 722
Lines ? 50616
Branches ? 6935
=============================================
Hits ? 23034
Misses ? 24621
Partials ? 2961
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4506f34...7191932](https://codecov.io/gh/apache/rocketmq/pull/3504?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org