[GitHub] chetanmeh opened a new pull request #4065: Include exception class in failure message from ArtifactStore

[GitBox <gi...@apache.org>]

chetanmeh opened a new pull request #4065: Include exception class in failure message from ArtifactStore
URL: https://github.com/apache/incubator-openwhisk/pull/4065
 
 
   Sometime the exception message is null which leads to log message like `'activations' internal error, failure: 'null'`
   
   ```
   [2018-10-11T06:46:11.034Z] [ERROR] [#tid_bASVetECuqu481V6WTm0f35UhQzqV2Zd] [StoreUtils] [QUERY] 'activations' internal error, failure: 'null' [marker:database_queryView_error:120:120]
   ```
   
   To get more context of the actual exception it would be useful to also include the exception class. Post this the log would be like
   
   ```
   [2018-10-12T09:00:39.758Z] [ERROR] [#tid_sid_testing] [StoreUtils] Test null [RuntimeException] [marker:database_getDocumentAttachment_error:739:29]
   ```
   
   
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [ ] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [ ] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [ ] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).
   - [ ] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [ ] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services