You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by da...@apache.org on 2014/01/31 19:18:55 UTC
[5/5] git commit: updated refs/heads/4.3 to 8c45ab0
findbugs Long comparison == -> equals()
(cherry picked from commit f4db8df66fbcb5df3cd9bbf607ede9a4d514fe4a)
Signed-off-by: Daan Hoogland <da...@onecht.net>
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/8c45ab07
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/8c45ab07
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/8c45ab07
Branch: refs/heads/4.3
Commit: 8c45ab0761c533a26467fc89c9ca6d2424a720fb
Parents: 6aa3fd8
Author: Daan Hoogland <da...@onecht.net>
Authored: Fri Jan 31 09:07:55 2014 +0100
Committer: Daan Hoogland <da...@onecht.net>
Committed: Fri Jan 31 19:17:58 2014 +0100
----------------------------------------------------------------------
server/src/com/cloud/template/TemplateManagerImpl.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/8c45ab07/server/src/com/cloud/template/TemplateManagerImpl.java
----------------------------------------------------------------------
diff --git a/server/src/com/cloud/template/TemplateManagerImpl.java b/server/src/com/cloud/template/TemplateManagerImpl.java
index 681be4a..3bfe5c8 100755
--- a/server/src/com/cloud/template/TemplateManagerImpl.java
+++ b/server/src/com/cloud/template/TemplateManagerImpl.java
@@ -1801,7 +1801,7 @@ public class TemplateManagerImpl extends ManagerBase implements TemplateManager,
}
// Don't allow to modify system template
- if (id == Long.valueOf(1)) {
+ if (Long.valueOf(1).equals(id)) {
InvalidParameterValueException ex = new InvalidParameterValueException("Unable to update template/iso of specified id");
ex.addProxyObject(String.valueOf(id), "templateId");
throw ex;