You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/10/11 09:48:16 UTC
Review Request: Updated process::http::Response (and subclasses) to require
more explicit distinction between an empty body and no body. Also put in
place the foundation for streaming via pipes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7542/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/include/process/http.hpp 3d2922507bdb904e5bdebefbafb6ccae98c021c4
third_party/libprocess/src/encoder.hpp 00e86610257b4956ceed13cd3e27e948ea53308e
Diff: https://reviews.apache.org/r/7542/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Updated process::http::Response (and subclasses) to
require more explicit distinction between an empty body and no body. Also
put in place the foundation for streaming via pipes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7542/#review12418
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Oct. 13, 2012, 12:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7542/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2012, 12:02 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/http.hpp d6dba532670daa599ab446f9a4e79f3fdec81e07
> third_party/libprocess/src/encoder.hpp 00e86610257b4956ceed13cd3e27e948ea53308e
>
> Diff: https://reviews.apache.org/r/7542/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated process::http::Response (and subclasses) to
require more explicit distinction between an empty body and no body. Also
put in place the foundation for streaming via pipes.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7542/
-----------------------------------------------------------
(Updated Oct. 13, 2012, 12:02 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Updates from review comments.
Description
-------
See summary.
Diffs (updated)
-----
third_party/libprocess/include/process/http.hpp d6dba532670daa599ab446f9a4e79f3fdec81e07
third_party/libprocess/src/encoder.hpp 00e86610257b4956ceed13cd3e27e948ea53308e
Diff: https://reviews.apache.org/r/7542/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Updated process::http::Response (and subclasses) to
require more explicit distinction between an empty body and no body. Also
put in place the foundation for streaming via pipes.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7542/#review12364
-----------------------------------------------------------
third_party/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/7542/#comment26163>
Giant paragraph comment, I think breaking this comment down per-type would be clearer.
Maybe be a bit clearer on what the pipe provider needs to handle? Does he/she need to specifically handle SIGPIPE?
third_party/libprocess/src/encoder.hpp
<https://reviews.apache.org/r/7542/#comment26164>
'headers' is now a hashmap, which has contains().
third_party/libprocess/src/encoder.hpp
<https://reviews.apache.org/r/7542/#comment26165>
ditto
- Ben Mahler
On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7542/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2012, 7:48 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/include/process/http.hpp 3d2922507bdb904e5bdebefbafb6ccae98c021c4
> third_party/libprocess/src/encoder.hpp 00e86610257b4956ceed13cd3e27e948ea53308e
>
> Diff: https://reviews.apache.org/r/7542/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>