You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/04/28 06:43:05 UTC

[GitHub] flink pull request #5936: [FLINK-9265] Upgrade Prometheus version

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5936

    [FLINK-9265] Upgrade Prometheus version

    ## What is the purpose of the change
    
    *This pull request upgrades the prometheus's version to the latest version*
    
    
    ## Brief change log
    
      - *Upgrade the prometheus version*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (**yes** / no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-9265

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5936.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5936
    
----
commit e29ddaa56d8236c7df284b9f818c24df662c395b
Author: yanghua <ya...@...>
Date:   2018-04-28T06:38:16Z

    [FLINK-9265] Upgrade Prometheus version

----


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5936
  
    Yes, before giving +1 to this commit, we need to check that this introduces no new transitive dependency, or need to make sure that dependency is not an issue.


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5936
  
    Could you add the dependency tree of the upgraded Prometheus dependency to check?


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5936
  
    cc @StephanEwen , here is the dependency tree : 
    
    ```
    [INFO] org.apache.flink:flink-metrics-prometheus:jar:1.6-SNAPSHOT
    [INFO] +- io.prometheus:simpleclient:jar:0.3.0:compile
    [INFO] \- io.prometheus:simpleclient_httpserver:jar:0.3.0:compile
    [INFO]    +- (io.prometheus:simpleclient:jar:0.3.0:compile - omitted for duplicate)
    [INFO]    \- io.prometheus:simpleclient_common:jar:0.3.0:compile
    [INFO]       \- (io.prometheus:simpleclient:jar:0.3.0:compile - omitted for duplicate)
    ```


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5936
  
    Looks good, thanks.
    
    +1 to merge this


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

Posted by yanghua <gi...@git.apache.org>.

Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/5936
  
    Is there any problem about this upgrading?  Does you mean I should add the dependency tree here as a comment? 


---

[GitHub] flink pull request #5936: [FLINK-9265] Upgrade Prometheus version

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5936


---

[GitHub] flink issue #5936: [FLINK-9265] Upgrade Prometheus version

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5936
  
    merging.


---