[jira] [Commented] (OOZIE-1846) Convert CoordActionMaterializeCommand to an XCommand and remove Command

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028967#comment-14028967 ] 

Hadoop QA commented on OOZIE-1846:
----------------------------------

Testing JIRA OOZIE-1846

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 2 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1464
.    Tests failed: 2
.    Tests errors: 0

.    The patch failed the following testcases:

.      testTimeoutWithException(org.apache.oozie.command.coord.TestCoordActionInputCheckXCommandNonUTC)
.      testCoordinatorActionCommandsSubmitAndStart(org.apache.oozie.sla.TestSLAEventGeneration)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1308/

> Convert CoordActionMaterializeCommand to an XCommand and remove Command
> -----------------------------------------------------------------------
>
>                 Key: OOZIE-1846
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1846
>             Project: Oozie
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 4.0.1
>            Reporter: Robert Kanter
>         Attachments: OOZIE-1846.1.patch
>
>
> {{CoordActionMaterializeCommand}} is only used in one place where we do a coordinator dryrun ({{CoordSubmitXCommand.getDryRun(...)}}); otherwise, {{CoordMaterializeTransitionXCommand}} is normally used.
> {{CoordActionMaterializeCommand}} appears to be the only class left still based on {{Command}}; everything else is using {{XCommand}}.  We should update the code that uses {{CoordActionMaterializeCommand}} to use {{CoordMaterializeTransitionXCommand}} instead.  Then we could completely remove {{Comamnd}}.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)