You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by cxxjava <gi...@git.apache.org> on 2018/03/05 01:21:51 UTC
[GitHub] zookeeper pull request #480: c++ zookeeper
GitHub user cxxjava opened a pull request:
https://github.com/apache/zookeeper/pull/480
c++ zookeeper
c++ zookeeper base java zookeeper v3.4.11
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cxxjava/zookeeper CxxZookeeper
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/480.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #480
----
commit 63b1f92102877757815eec5e0866b7a143868e2d
Author: Camille Fournier <ca...@...>
Date: 2013-12-11T18:31:05Z
ZOOKEEPER-1382. Zookeeper server holds onto dead/expired session ids in the watch data structures
(Germán Blanco and Michael Morello via camille)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550220 13f79535-47bb-0310-9956-ffa450edef68
commit fc22886f0c12c0b28780dc29a10c334d1221d9b9
Author: Michi Mutsuzaki <mi...@...>
Date: 2013-12-14T08:36:46Z
ZOOKEEPER-1715. Upgrade netty version (Sean Bridges via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550902 13f79535-47bb-0310-9956-ffa450edef68
commit ec70dd2c43bc1d780a480487fe4437cb95d01e65
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-14T11:23:24Z
ZOOKEEPER-1837. Fix JMXEnv checks (potential race conditions) (Germán Blanco via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1550923 13f79535-47bb-0310-9956-ffa450edef68
commit 7e1c76814a267d52c4392c7c181e116b3eb31233
Author: Michi Mutsuzaki <mi...@...>
Date: 2013-12-16T04:20:40Z
ZOOKEEPER-1839. Deadlock in NettyServerCnxn (Rakesh R via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551112 13f79535-47bb-0310-9956-ffa450edef68
commit a6dec3afdae22bafd8e8fd3c56b258b2a3bbabe8
Author: Patrick D. Hunt <ph...@...>
Date: 2013-12-16T06:27:56Z
ZOOKEEPER-1622. session ids will be negative in the year 2022 (Eric Newton via phunt)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551118 13f79535-47bb-0310-9956-ffa450edef68
commit 5dd0361a5db1e2a5f998344c8abdd0751988eba1
Author: Michi Mutsuzaki <mi...@...>
Date: 2013-12-16T21:49:50Z
ZOOKEEPER-1756. zookeeper_interest() in C client can return a timeval of 0 (Eric Lindvall via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551367 13f79535-47bb-0310-9956-ffa450edef68
commit 6c483a2d67d4aee937e0f4873e4b410b7008e703
Author: Patrick D. Hunt <ph...@...>
Date: 2013-12-17T16:57:03Z
ZOOKEEPER-1388. Client side 'PathValidation' is missing for the multi-transaction api. (Rakesh R via marshallm, phunt)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551625 13f79535-47bb-0310-9956-ffa450edef68
commit 54eefdb4fc57e18f28bbb520e4abb163de2f936a
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-18T13:05:31Z
ZOOKEEPER-1841. problem in QuorumTest (Germán via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551930 13f79535-47bb-0310-9956-ffa450edef68
commit 5420ead4bb71dfa83f09c4cce72fa72e649eac62
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-18T15:48:19Z
ZOOKEEPER-1733. FLETest#testLE is flaky on windows boxes
(michim via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551985 13f79535-47bb-0310-9956-ffa450edef68
commit 058185d6359393e3898acd745f341f1799b276ce
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-18T15:52:16Z
ZOOKEEPER-1733. FLETest#testLE is flaky on windows boxes
(michim, Jeffrey Zhong via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1551987 13f79535-47bb-0310-9956-ffa450edef68
commit 7b272f5d5e4d1c170bc72c9b79a462517c06d6d4
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-19T22:36:08Z
ZOOKEEPER-1849. Need to properly tear down tests in various
cases (Germán via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1552447 13f79535-47bb-0310-9956-ffa450edef68
commit 05bc123a83d0e355f703001c78b3a54988c678e4
Author: Patrick D. Hunt <ph...@...>
Date: 2013-12-20T01:29:22Z
ZOOKEEPER-1430. add maven deploy support to the build (Giridharan Kesavan via phunt)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1552470 13f79535-47bb-0310-9956-ffa450edef68
commit 7fc3de3a05c9ace88b0e6b914750b2712f43f7c0
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-27T13:29:08Z
ZOOKEEPER-1179. NettyServerCnxn does not properly close
socket on 4 letter word requests (Rakesh R, Germán Blanco
via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1553672 13f79535-47bb-0310-9956-ffa450edef68
commit 80ef32504a46387e051ca9b58e1b5b58b387b358
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2013-12-27T16:50:46Z
ZOOKEEPER-1179. NettyServerCnxn does not properly close socket on 4 letter word requests. (Rakesh R, Germán Blanco via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1553694 13f79535-47bb-0310-9956-ffa450edef68
commit 68a0f7315d59f4a8090b3a08bb8dab8453bb2fe9
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-01-03T00:23:23Z
ZOOKEEPER-1852. ServerCnxnFactory instance is not properly cleanedup (Rakesh R via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1554979 13f79535-47bb-0310-9956-ffa450edef68
commit 89448077733a8d025734b79346e403cbcdaa9cea
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-01-03T00:44:27Z
ZOOKEEPER-1852. ServerCnxnFactory instance is not properly cleanedup (Rakesh R via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1554983 13f79535-47bb-0310-9956-ffa450edef68
commit ca8d611d2db1234bfc0a3f64f2a2a8a15021c8a3
Author: Michi Mutsuzaki <mi...@...>
Date: 2014-01-09T19:22:57Z
ZOOKEEPER-1414. QuorumPeerMainTest.testQuorum, testBadPackets are failing intermittently (Rakesh R via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556926 13f79535-47bb-0310-9956-ffa450edef68
commit a6528185040b0f782c3d59650b694cf478e01b6a
Author: Michi Mutsuzaki <mi...@...>
Date: 2014-01-09T21:03:16Z
ZOOKEEPER-1057. zookeeper c-client, connection to offline server fails to successfully fallback to second zk host (Germán Blanco via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556949 13f79535-47bb-0310-9956-ffa450edef68
commit 19e4b850e48cbe8f100ab23cada9f2ea0a05d2be
Author: Michi Mutsuzaki <mi...@...>
Date: 2014-01-09T23:01:19Z
ZOOKEEPER-1857. PrepRequestProcessotTest doesn't shutdown ZooKeeper server (Germán Blanco via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1556977 13f79535-47bb-0310-9956-ffa450edef68
commit 9436a70a24d62d38afea2692d2413bd935981b83
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-01-12T21:36:17Z
ZOOKEEPER-1238. when the linger time was changed for NIO the patch missed
Netty (Skye Wanderman-Milne via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1557614 13f79535-47bb-0310-9956-ffa450edef68
commit 2a7782057185f43b4b8dd66167e90a4bafeb0a3a
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-01-16T22:59:54Z
ZOOKEEPER-1837. Fix JMXEnv checks (potential race conditions)
(Germán Blanco via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1558951 13f79535-47bb-0310-9956-ffa450edef68
commit 57295cc197052c13387589bc7e1cbf5007f6612d
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-01-24T17:06:22Z
ZOOKEEPER-1858. JMX checks - potential race conditions while stopping and starting server (Rakesh R via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1561069 13f79535-47bb-0310-9956-ffa450edef68
commit d25a054da357cf1fcad07f80131d69434416a73b
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-01-27T13:38:03Z
ZOOKEEPER-1867. Bug in ZkDatabaseCorruptionTest (fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1561673 13f79535-47bb-0310-9956-ffa450edef68
commit ea52795eb7e27024bd00ad4ebef1e99c0012574b
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-02-09T22:24:55Z
ZOOKEEPER-1872. QuorumPeer is not shutdown in few cases (Rakesh R via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1566453 13f79535-47bb-0310-9956-ffa450edef68
commit efec318a6a95417f934b34f468aaabece5784a0a
Author: Patrick D. Hunt <ph...@...>
Date: 2014-02-10T20:52:25Z
ZOOKEEPER-1573. Unable to load database due to missing parent node (Vinayakumar B via phunt, fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1566740 13f79535-47bb-0310-9956-ffa450edef68
commit 3cf7cfc21c69f38f97cc059ed37abe8f356bcef7
Author: Patrick D. Hunt <ph...@...>
Date: 2014-02-10T21:26:54Z
ZOOKEEPER-1811. The ZooKeeperSaslClient service name principal is hardcoded to "zookeeper" (Harsh J via phunt)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1566749 13f79535-47bb-0310-9956-ffa450edef68
commit c6a3d5bc921b1a68be76c6fcf2750fae176e8358
Author: Michi Mutsuzaki <mi...@...>
Date: 2014-02-12T01:43:10Z
ZOOKEEPER-1873. Unnecessarily InstanceNotFoundException is coming when unregister failed jmxbeans (Rakesh R via michim)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1567490 13f79535-47bb-0310-9956-ffa450edef68
commit a5065590468b0c2a8dbed0bba8391bd5153c0217
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-02-12T16:00:34Z
ZOOKEEPER-1844. TruncateTest fails on windows (Rakesh R via fpj)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1567661 13f79535-47bb-0310-9956-ffa450edef68
commit 67155d1f38a20d07b2248880561fda714418e5fa
Author: Camille Fournier <ca...@...>
Date: 2014-02-19T01:29:43Z
ZOOKEEPER-1755. Concurrent operations of four letter 'dump' ephemeral
command and killSession causing NPE (Rakesh R via camille)
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1569588 13f79535-47bb-0310-9956-ffa450edef68
commit e84dd9004661dde04bc738e75bb02c67ae09347a
Author: Flavio Paiva Junqueira <fp...@...>
Date: 2014-02-19T23:07:59Z
Preparing for release 3.4.6
git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.4@1569958 13f79535-47bb-0310-9956-ffa450edef68
----
---
[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/480
@cxxjava :
Is this for your C++ version of ZK as https://github.com/cxxjava/CxxZookeeper?
If so please follow the guidelines on https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute before creating a pull request. In particular please create a JIRA issue as document for your feature proposal.
---
[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11
Posted by cxxjava <gi...@git.apache.org>.
Github user cxxjava commented on the issue:
https://github.com/apache/zookeeper/pull/480
@hanm
I use c++ like java (CxxZookeeper third party include CxxJDK, it's another project, like jdk), all code is the same logic as java ZK.
Current CxxZookeeper is sync to java ZK v3.4.11, so the bugs in java ZK v3.4.11 is also in CxxZookeeper.
---
[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/480
@cxxjava Sorry if I was not very clear on my previous comments. The normal process of proposing a big feature like this is to first discuss it on developer mailing list and also at the same time create a JIRA issue to track the proposal. So what you'd probably want to do if your goal is to get this contributed back to ZK source repo:
* Sign up the ZooKeeper developer mailing list:
http://zookeeper.apache.org/lists.html
* Create a JIRA issues (sign up JIRA if you don't have an account)
https://issues.apache.org/jira/projects/ZOOKEEPER/
Then we can go from there.
>> btw, can you speak Chinese?
我可以 :) - but let's keep discussions in english as that's the language which this community is operating on.
I haven't looked into details of your c++ version of ZK but it's impressive amount of work to get it compatible with ZK. What kind of testing did you do to make sure your server is compatible with existing ZK clients / client applications?
---
[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11
Posted by maoling <gi...@git.apache.org>.
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/480
I can
@cxxjava
你是Pull Request pull错了！！忘记 git fetch upstream
把所有的commits都push进来了!
这个中文[文档](https://zhuanlan.zhihu.com/p/23457016)很详细
---
[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11
Posted by cxxjava <gi...@git.apache.org>.
Github user cxxjava commented on the issue:
https://github.com/apache/zookeeper/pull/480
@maoling
[CxxZookeeper](https://github.com/cxxjava/CxxZookeeper)是用c++重写了一遍，所有逻辑都是直接复制java版zk，所以CxxZookeeper的逻辑正确性同步官方zk。在未深入优化的情况下，c++版性能只是接近java版，并未超越，所以还无法革zk的命(主要原因是c++的concurrent库性能还不及java版)，但内存使用优势明显，下面是生产环境下的快照：
c++ zk : <img width="770" alt="zk_cpp_top" src="https://user-images.githubusercontent.com/14046581/37010891-af055dba-2128-11e8-8e5e-d3d80d1f87fb.png">
java zk: <img width="766" alt="zk_java_top" src="https://user-images.githubusercontent.com/14046581/37010892-af3d2b0a-2128-11e8-8881-e8f6628cb2a9.png">
---
[GitHub] zookeeper issue #480: c++ zookeeper base java zookeeper v3.4.11
Posted by cxxjava <gi...@git.apache.org>.
Github user cxxjava commented on the issue:
https://github.com/apache/zookeeper/pull/480
@hanm
After reading [HowToContribute](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute), I yet don't how to create a pull request for CxxZookeeper, it's use c++ programing language.
btw, can you speak Chinese?
---