[GitHub] [netbeans] ppisl commented on a diff in pull request #4495: Support for project output artifacts

[GitBox <gi...@apache.org>]

ppisl commented on code in PR #4495:
URL: https://github.com/apache/netbeans/pull/4495#discussion_r949140308


##########
ide/project.dependency/src/org/netbeans/modules/project/dependency/ArtifactSpec.java:
##########
@@ -75,17 +86,45 @@ public enum VersionKind {
         this.optional = optional;
         this.data = impl;
         this.type = type;
+        this.location = location;
         this.localFile = localFile;
     }
 
     public T getData() {
         return data;
     }
 
+    /**
+     * Returns local file which the artifact represents. For library (dependencies) artifacts,
+     * the file is the library consumed, e.g. from a local repository. For outputs, the artifact
+     * represents the build output, usually in project's build directory. Note that FileObject for 
+     * a dependency and its corresponding Project may not be the same.
+     * 

Review Comment:
   Probably there should be mentioned, that can return null, if the local file doesn't exist?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists