You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2011/12/14 01:09:29 UTC
[jira] [Created] (LUCENE-3646) throw exception for fieldcache on a
non-atomic reader
throw exception for fieldcache on a non-atomic reader
-----------------------------------------------------
Key: LUCENE-3646
URL: https://issues.apache.org/jira/browse/LUCENE-3646
Project: Lucene - Java
Issue Type: Task
Reporter: Robert Muir
Fix For: 4.0
Attachments: LUCENE-3646.patch
In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3646) throw exception for fieldcache on
a non-atomic reader
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187772#comment-13187772 ]
Uwe Schindler commented on LUCENE-3646:
---------------------------------------
I just committed a last chance to register a purge event if the slow reader does not even have a IndexReader instance as cache key (like SlowMultiReaderWrapper).
> throw exception for fieldcache on a non-atomic reader
> -----------------------------------------------------
>
> Key: LUCENE-3646
> URL: https://issues.apache.org/jira/browse/LUCENE-3646
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: FieldCacheImpl.java.patch, LUCENE-3646.patch
>
>
> In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
> DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
> But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
> I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3646) throw exception for fieldcache on a
non-atomic reader
Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-3646:
--------------------------------
Attachment: LUCENE-3646.patch
Attached is an initial patch... all tests pass.
> throw exception for fieldcache on a non-atomic reader
> -----------------------------------------------------
>
> Key: LUCENE-3646
> URL: https://issues.apache.org/jira/browse/LUCENE-3646
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-3646.patch
>
>
> In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
> DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
> But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
> I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3646) throw exception for fieldcache on a
non-atomic reader
Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-3646.
---------------------------------
Resolution: Fixed
> throw exception for fieldcache on a non-atomic reader
> -----------------------------------------------------
>
> Key: LUCENE-3646
> URL: https://issues.apache.org/jira/browse/LUCENE-3646
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-3646.patch
>
>
> In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
> DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
> But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
> I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3646) throw exception for fieldcache on
a non-atomic reader
Posted by "Uwe Schindler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169531#comment-13169531 ]
Uwe Schindler commented on LUCENE-3646:
---------------------------------------
+1, let's get rid of this!
I only comitted a change to FieldCacheImpl that made the 2 listeners reused and per-instance of FCImpl.
> throw exception for fieldcache on a non-atomic reader
> -----------------------------------------------------
>
> Key: LUCENE-3646
> URL: https://issues.apache.org/jira/browse/LUCENE-3646
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-3646.patch
>
>
> In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
> DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
> But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
> I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3646) throw exception for fieldcache on a
non-atomic reader
Posted by "Uwe Schindler (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-3646:
----------------------------------
Attachment: FieldCacheImpl.java.patch
A small relict of very old code already fixed when we redid the listeners. The patch was just very old :-). I just fixed in the attached patch, will commit now.
> throw exception for fieldcache on a non-atomic reader
> -----------------------------------------------------
>
> Key: LUCENE-3646
> URL: https://issues.apache.org/jira/browse/LUCENE-3646
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: FieldCacheImpl.java.patch, LUCENE-3646.patch
>
>
> In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
> DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
> But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
> I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3646) throw exception for fieldcache on
a non-atomic reader
Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169509#comment-13169509 ]
Michael McCandless commented on LUCENE-3646:
--------------------------------------------
+1, looks great. Nice how few places required SlowMR wrapping....
> throw exception for fieldcache on a non-atomic reader
> -----------------------------------------------------
>
> Key: LUCENE-3646
> URL: https://issues.apache.org/jira/browse/LUCENE-3646
> Project: Lucene - Java
> Issue Type: Task
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-3646.patch
>
>
> In Lucene 4.0, we go through a lot of effort to prevent slow uses of non-atomic readers:
> DirectoryReader/MultiReader etc throw exception if you don't try to access postings or docvalues apis per-segment, etc.
> But the biggest trap of all is still too easy to fall into, we don't do the same for FieldCache.
> I think we should throw exception, forcing the user to either change their code or use a SlowMultiReaderWrapper.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org