You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/18 09:25:03 UTC
[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #4388: Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure
HangyuanLiu opened a new pull request #4388:
URL: https://github.com/apache/incubator-doris/pull/4388
## Proposed changes
In the process of historical data transformation of materialized views, it may occur that the transformation fails due to data quality.
Add an error status code ：` OLAP_ERR_DATE_QUALITY_ERR ` to determine if a data problem is causing the failure
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4388: Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4388:
URL: https://github.com/apache/incubator-doris/pull/4388#discussion_r472790759
##########
File path: be/src/olap/olap_define.h
##########
@@ -305,6 +305,7 @@ enum OLAPStatus {
OLAP_ERR_PREVIOUS_SCHEMA_CHANGE_NOT_FINISHED = -1603,
OLAP_ERR_SCHEMA_CHANGE_INFO_INVALID = -1604,
OLAP_ERR_QUERY_SPLIT_KEY_ERR = -1605,
+ OLAP_ERR_DATE_QUALITY_ERR = -1606,
Review comment:
Maybe DATA ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #4388: Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #4388:
URL: https://github.com/apache/incubator-doris/pull/4388#discussion_r474424442
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -385,37 +385,37 @@ bool count_field(RowCursor* read_helper, RowCursor* write_helper, const TabletCo
return true;
}
-bool RowBlockChanger::change_row_block(const RowBlock* ref_block, int32_t data_version,
+OLAPStatus RowBlockChanger::change_row_block(const RowBlock* ref_block, int32_t data_version,
RowBlock* mutable_block, uint64_t* filtered_rows) const {
if (mutable_block == nullptr) {
LOG(FATAL) << "mutable block is uninitialized.";
- return false;
+ return OLAP_ERR_NOT_INITED;
Review comment:
Could you please add docs to explain what these error codes mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 merged pull request #4388: Add OLAP_ERR_DATE_QUALITY_ERR error status to display schema change failure
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged pull request #4388:
URL: https://github.com/apache/incubator-doris/pull/4388
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org