You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by "warren830 (via GitHub)" <gi...@apache.org> on 2023/02/16 16:04:34 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #4436: feat(action): add new workflow
warren830 opened a new pull request, #4436:
URL: https://github.com/apache/incubator-devlake/pull/4436
### Summary
First try to automatically upgrade helm
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] matrixji commented on a diff in pull request #4436: feat(action): add new workflow
Posted by "matrixji (via GitHub)" <gi...@apache.org>.
matrixji commented on code in PR #4436:
URL: https://github.com/apache/incubator-devlake/pull/4436#discussion_r1109311530
##########
.github/workflows/helm-upgrade.yaml:
##########
@@ -0,0 +1,30 @@
+name: Update chart
+
+on:
+ push:
+ tags:
+ - '*'
+jobs:
+ update-chart:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-devlake
+ ref: ${{ github.ref }}
+ - name: Download helm chart repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-devlake-helm-chart
+ ref: master
+ - name: Update chart.yaml
+ run: |
+ sed -i 's/version:.*/version: ${{ github.ref }}/' charts/devlake/Chart.yaml
Review Comment:
Need also to modify `appVersion` in Chart.yaml
##########
.github/workflows/helm-upgrade.yaml:
##########
@@ -0,0 +1,30 @@
+name: Update chart
+
+on:
+ push:
+ tags:
+ - '*'
+jobs:
+ update-chart:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-devlake
+ ref: ${{ github.ref }}
+ - name: Download helm chart repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-devlake-helm-chart
+ ref: master
+ - name: Update chart.yaml
+ run: |
+ sed -i 's/version:.*/version: ${{ github.ref }}/' charts/devlake/Chart.yaml
+ - name: Update values.yaml
+ run: |
+ sed -i 's/imageTag:.*/imageTag: ${{ github.ref }}/' charts/devlake/values.yaml
+ - name: Commit and Push changes
Review Comment:
We could also modify `--version=xxx` in README.md
##########
.github/workflows/helm-upgrade.yaml:
##########
@@ -0,0 +1,30 @@
+name: Update chart
+
+on:
+ push:
+ tags:
+ - '*'
+jobs:
+ update-chart:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-devlake
+ ref: ${{ github.ref }}
+ - name: Download helm chart repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-devlake-helm-chart
+ ref: master
+ - name: Update chart.yaml
+ run: |
+ sed -i 's/version:.*/version: ${{ github.ref }}/' charts/devlake/Chart.yaml
+ - name: Update values.yaml
+ run: |
+ sed -i 's/imageTag:.*/imageTag: ${{ github.ref }}/' charts/devlake/values.yaml
+ - name: Commit and Push changes
+ run: |
+ git add .
+ git commit -m "Update chart to version ${{ github.ref }}"
+ git push origin version-${{ github.ref }}
Review Comment:
Not suggest push commits to master directly, suggest creating PR instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on pull request #4436: feat(action): add new workflow
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 commented on PR #4436:
URL: https://github.com/apache/incubator-devlake/pull/4436#issuecomment-1478810995
fixed by #4607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 closed pull request #4436: feat(action): add new workflow
Posted by "warren830 (via GitHub)" <gi...@apache.org>.
warren830 closed pull request #4436: feat(action): add new workflow
URL: https://github.com/apache/incubator-devlake/pull/4436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org