You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Greg Miller (Jira)" <ji...@apache.org> on 2021/08/26 14:02:00 UTC
[jira] [Resolved] (LUCENE-10060) Ensure DrillSidewaysQuery
instances don't get cached
[ https://issues.apache.org/jira/browse/LUCENE-10060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Miller resolved LUCENE-10060.
----------------------------------
Fix Version/s: 8.10
main (9.0)
Resolution: Fixed
> Ensure DrillSidewaysQuery instances don't get cached
> ----------------------------------------------------
>
> Key: LUCENE-10060
> URL: https://issues.apache.org/jira/browse/LUCENE-10060
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
> Fix For: main (9.0), 8.10
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We need to make sure DSQ instances don't end up in the query cache. -It's important that the {{DrillSidewaysScorer}} (bulk scorer implementation) actually runs during query evaluation in order to populate the "sideways" {{FacetsCollector}} instances with "near miss" docs. If it gets cached, this won't happen.-
> There may also be an implication around {{acceptDocs}} getting honored as well. [~zacharymorn] may be able to provide more details.
> UPDATE: The original issue I detailed above isn't actually an issue since {{DrillDownQuery}} doesn't implement {{equals}}, so the cache always misses and it always executes the {{BulkScorer}} ( {{DrillSidewaysScorer}} ). Tricky! There is a separate issue found by Zach (as mentioned above) related to "acceptDocs" though. See below conversation and link off to the separate [PR conversation|https://github.com/apache/lucene/pull/240#discussion_r692154001] for more details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org