[GitHub] yoonian closed pull request #5465: Fix typos & Add athena description

[GitBox <gi...@apache.org>]

yoonian closed pull request #5465: Fix typos & Add athena description
URL: https://github.com/apache/incubator-superset/pull/5465
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/installation.rst b/docs/installation.rst
index 2ea52002b8..0a94dbf41c 100644
--- a/docs/installation.rst
+++ b/docs/installation.rst
@@ -364,11 +364,11 @@ Where you need to escape/encode at least the s3_staging_dir, i.e., ::
 
     s3://... -> s3%3A//...
 
-You can also use `PyAthena` library
+You can also use `PyAthena` library - it doesn't use JDBC driver.
 
     awsathena+rest://{aws_access_key_id}:{aws_secret_access_key}@athena.{region_name}.amazonaws.com/{schema_name}?s3_staging_dir={s3_staging_dir}&...
 
-_(See more details at https://github.com/laughingman7743/PyAthena#sqlalchemy.)_
+See `PyAthena <https://github.com/laughingman7743/PyAthena#sqlalchemy>`_.
 
 Snowflake
 ---------
@@ -386,7 +386,7 @@ Make sure the user has privileges to access and use all required
 databases/schemas/tables/views/warehouses, as the Snowflake SQLAlchemy engine does
 not test for user rights during engine creation.
 
-_(See more details at https://github.com/snowflakedb/snowflake-sqlalchemy.)_
+See `Snowflake SQLAlchemy <https://github.com/snowflakedb/snowflake-sqlalchemy>`_.
 
 Caching
 -------


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org