[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

[kishankavala <gi...@git.apache.org>]

Github user kishankavala commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/780#discussion_r56311601
  
    --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java ---
    @@ -3332,7 +3332,14 @@ public PowerState getVmState(final Connection conn, final String vmName) {
                         vmStatsAnswer.setDiskReadKBs(vmStatsAnswer.getDiskReadKBs() + getDataAverage(dataNode, col, numRows) / 1000);
                     } else if (param.matches("vbd_.*_write")) {
                         vmStatsAnswer.setDiskWriteKBs(vmStatsAnswer.getDiskWriteKBs() + getDataAverage(dataNode, col, numRows) / 1000);
    +                } else if (param.contains("memory_internal_free")) {
    +                    vmStatsAnswer.setIntFreeMemoryKBs(vmStatsAnswer.getIntFreeMemoryKBs() + getDataAverage(dataNode, col, numRows) / 1000);
    --- End diff --
    
    Bytes to KB conversion should use 1024 instead of 1000


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---