You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/29 11:35:08 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37

JingsongLi commented on a change in pull request #9239: [FLINK-13385]Align Hive data type mapping with FLIP-37
URL: https://github.com/apache/flink/pull/9239#discussion_r308182050
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
 ##########
 @@ -146,6 +143,11 @@ public static TypeInfo toHiveTypeInfo(DataType dataType) {
 			// Flink's primitive types that Hive 2.3.4 doesn't support: Time, TIMESTAMP_WITH_LOCAL_TIME_ZONE
 		}
 
+		if (dataType.equals(DataTypes.BYTES())) {
 
 Review comment:
   This way will equals nullable, you should put this code in switch case, and check length.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services