You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 14:23:15 UTC
[GitHub] [airflow] sbrandtb opened a new issue, #25446: Helm Chart: Allow adding annotations to statsd deployment
sbrandtb opened a new issue, #25446:
URL: https://github.com/apache/airflow/issues/25446
### Description
Helm Chart does not allow adding annotations to StatsD deployment. We should add it.
### Use case/motivation
In our Kubernetes cluster we need to set annotations on deployments that should be scraped by Prometheus. Having an exporter that does not get scraped defeats the purpose :slightly_smiling_face:
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #25446:
URL: https://github.com/apache/airflow/issues/25446#issuecomment-1218093180
I assigned you now @sbrandtb but I am happy to co-assign you as well @joshuaghezzi (but you need to comment here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sbrandtb commented on issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
sbrandtb commented on issue #25446:
URL: https://github.com/apache/airflow/issues/25446#issuecomment-1232757599
As I said: No offense. Just not a good job sticking to the process :slightly_smiling_face: I unassigned myself again because I am not part of the solution anymore. Waiting for this to be released, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham closed issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
jedcunningham closed issue #25446: Helm Chart: Allow adding annotations to statsd deployment
URL: https://github.com/apache/airflow/issues/25446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] sbrandtb commented on issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
sbrandtb commented on issue #25446:
URL: https://github.com/apache/airflow/issues/25446#issuecomment-1203960884
@jedcunningham Yes, that should be no problem. I just need to find some time for doing it. Probably not this week, but next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #25446:
URL: https://github.com/apache/airflow/issues/25446#issuecomment-1201274859
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #25446:
URL: https://github.com/apache/airflow/issues/25446#issuecomment-1202873343
@sbrandtb, would you be interested in opening a PR to add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] joshuaghezzi commented on issue #25446: Helm Chart: Allow adding annotations to statsd deployment
Posted by GitBox <gi...@apache.org>.
joshuaghezzi commented on issue #25446:
URL: https://github.com/apache/airflow/issues/25446#issuecomment-1218433241
@potiuk sounds good 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org