You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/21 03:19:09 UTC
[GitHub] [apisix-dashboard] membphis opened a new issue #1810: style(fe): how about changing the navigation bar to dark?
membphis opened a new issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810
![image](https://user-images.githubusercontent.com/6814606/115491834-46ffe600-a293-11eb-9fe1-d0887ccdc9f1.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-823775689
I We can directly try to see the modified effect.
cc @LiteSun @juzhiyuan @liuxiran @guoqqqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824523472
> @membphis @nic-chen Hi, we usually call it `Left Sidebar`.
>
> You could see this preview site: https://preview.pro.ant.design/dashboard/analysis
the dark mode LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824558758
We can also refer to the examples in the documentation: https://procomponents.ant.design/components/layout#menu~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552447
> > @membphis @nic-chen Hi, we usually call it `Left Sidebar`.
> > You could see this preview site: https://preview.pro.ant.design/dashboard/analysis
>
> the dark mode LGTM
me too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824097209
@membphis @nic-chen Hi, we usually call it `Left Sidebar`.
You could see this preview site: https://preview.pro.ant.design/dashboard/analysis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
iamayushdas removed a comment on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552447
> > @membphis @nic-chen Hi, we usually call it `Left Sidebar`.
> > You could see this preview site: https://preview.pro.ant.design/dashboard/analysis
>
> the dark mode LGTM
me too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
stu01509 commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824824042
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
iamayushdas edited a comment on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552808
Dark mode looks good as default. should we go for it ?
![scrnli_22_04_2021_11-04-17](https://user-images.githubusercontent.com/40708551/115661277-d0c6b680-a35a-11eb-8e70-d8ff79b5c32c.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun closed issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
LiteSun closed issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-825448305
Black looks more technological. LGTM+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824743044
Agree +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun closed issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
LiteSun closed issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824744063
+1 for sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824552808
Drk mode looks good as default. should we go for it ?
![scrnli_22_04_2021_11-04-17](https://user-images.githubusercontent.com/40708551/115661277-d0c6b680-a35a-11eb-8e70-d8ff79b5c32c.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824560255
> We can also refer to the examples in the documentation: https://procomponents.ant.design/components/layout#menu
Thanks for this😊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824999372
LGTM +1, dark mode draws a clear line between sidebar and content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] qier222 commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
qier222 commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824739344
Looks good😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi edited a comment on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
guoqqqi edited a comment on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824558758
We can also refer to the examples in the documentation: https://procomponents.ant.design/components/layout#menu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824738396
> Dark mode looks good as default. should we go for it ?
Hi, we need more members to review this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
starsz commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-825356436
LGTM +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824738688
cc @membphis @guoqqqi @stu01509 @qier222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1810: style(fe): how about changing the navigation bar to dark?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1810:
URL: https://github.com/apache/apisix-dashboard/issues/1810#issuecomment-824742654
ok, then vote +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org