You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Bilung Lee <bl...@gmail.com> on 2012/08/09 19:45:12 UTC
Review Request: SQOOP-532 Define intefaces for connector-defined execution
classes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5644/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
Define interfaces for connector-defined classes within the job execution lifecycle.
This addresses bug SQOOP-532.
https://issues.apache.org/jira/browse/SQOOP-532
Diffs
-----
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java 1370619
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 1370619
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 1370619
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java 1370619
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 1370619
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 1370619
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java PRE-CREATION
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 1370619
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Context.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 1370619
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 1370619
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 1370619
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 1370619
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 1370619
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataReader.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataWriter.java PRE-CREATION
Diff: https://reviews.apache.org/r/5644/diff/
Testing
-------
Thanks,
Bilung Lee
Re: Review Request: SQOOP-532 Define intefaces for connector-defined
execution classes
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5644/#review10310
-----------------------------------------------------------
Ship it!
The proposal looks good to me sir. Please attach the patch to JIRA and I'll commit.
- Jarek Cecho
On Aug. 14, 2012, 5:28 p.m., Bilung Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5644/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2012, 5:28 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> Define interfaces for connector-defined classes within the job execution lifecycle.
>
>
> This addresses bug SQOOP-532.
> https://issues.apache.org/jira/browse/SQOOP-532
>
>
> Diffs
> -----
>
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java 1372967
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 1372967
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 1372967
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java 1372967
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 1372967
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 1372967
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java PRE-CREATION
> /branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 1372967
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Context.java PRE-CREATION
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 1372967
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 1372967
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 1372967
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 1372967
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/MutableContext.java PRE-CREATION
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 1372967
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataReader.java PRE-CREATION
> /branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataWriter.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bilung Lee
>
>
Re: Review Request: SQOOP-532 Define intefaces for connector-defined
execution classes
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5644/
-----------------------------------------------------------
(Updated Aug. 14, 2012, 5:28 p.m.)
Review request for Sqoop.
Description
-------
Define interfaces for connector-defined classes within the job execution lifecycle.
This addresses bug SQOOP-532.
https://issues.apache.org/jira/browse/SQOOP-532
Diffs (updated)
-----
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportDestroyer.java 1372967
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java 1372967
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java 1372967
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportDestroyer.java 1372967
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java 1372967
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java 1372967
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java PRE-CREATION
/branches/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 1372967
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Context.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Destroyer.java 1372967
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Extractor.java 1372967
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java 1372967
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 1372967
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/MutableContext.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partition.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/etl/Partitioner.java 1372967
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataReader.java PRE-CREATION
/branches/sqoop2/spi/src/main/java/org/apache/sqoop/job/io/DataWriter.java PRE-CREATION
Diff: https://reviews.apache.org/r/5644/diff/
Testing
-------
Thanks,
Bilung Lee