[GitHub] spark pull request #17658: [SPARK-20355] Add per application spark version o...

[tgravescs <gi...@git.apache.org>]

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17658#discussion_r114363985
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -742,6 +743,7 @@ private[history] object FsHistoryProvider {
      *
      * @param logPath path to the log file, or, for a legacy log, its directory
      * @param name application name
    + * @param appSparkVersion application spark version
    --- End diff --
    
    nit move this param down below fileSize to match order in function


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org