You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2020/01/31 16:56:00 UTC
[Impala-ASF-CR] IMPALA-9335 (part 1): Rebase copied Kudu source code
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15143
Change subject: IMPALA-9335 (part 1): Rebase copied Kudu source code
......................................................................
IMPALA-9335 (part 1): Rebase copied Kudu source code
Removed be/src/kudu/{util|security|rpc} and copied back over from Kudu
commit: fc4ab691a502067bc4d5bdff30507cac7feb7cfe
Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/kudu/rpc/acceptor_pool.cc
M be/src/kudu/rpc/acceptor_pool.h
M be/src/kudu/rpc/blocking_ops.h
M be/src/kudu/rpc/client_negotiation.cc
M be/src/kudu/rpc/connection.cc
M be/src/kudu/rpc/connection.h
M be/src/kudu/rpc/constants.h
M be/src/kudu/rpc/inbound_call.cc
M be/src/kudu/rpc/inbound_call.h
M be/src/kudu/rpc/messenger.cc
M be/src/kudu/rpc/messenger.h
M be/src/kudu/rpc/mt-rpc-test.cc
M be/src/kudu/rpc/negotiation-test.cc
M be/src/kudu/rpc/negotiation.h
M be/src/kudu/rpc/outbound_call.cc
M be/src/kudu/rpc/outbound_call.h
M be/src/kudu/rpc/protoc-gen-krpc.cc
M be/src/kudu/rpc/proxy.h
M be/src/kudu/rpc/reactor.cc
M be/src/kudu/rpc/reactor.h
M be/src/kudu/rpc/remote_method.h
M be/src/kudu/rpc/response_callback.h
M be/src/kudu/rpc/result_tracker.cc
M be/src/kudu/rpc/retriable_rpc.h
M be/src/kudu/rpc/rpc-bench.cc
M be/src/kudu/rpc/rpc-test-base.h
M be/src/kudu/rpc/rpc-test.cc
M be/src/kudu/rpc/rpc.cc
M be/src/kudu/rpc/rpc.h
M be/src/kudu/rpc/rpc_context.cc
M be/src/kudu/rpc/rpc_context.h
M be/src/kudu/rpc/rpc_controller.cc
M be/src/kudu/rpc/rpc_controller.h
M be/src/kudu/rpc/rpc_header.proto
M be/src/kudu/rpc/rpc_introspection.proto
M be/src/kudu/rpc/rpc_service.h
M be/src/kudu/rpc/rpc_sidecar.h
M be/src/kudu/rpc/rpc_stub-test.cc
A be/src/kudu/rpc/rpc_verification_util.cc
A be/src/kudu/rpc/rpc_verification_util.h
M be/src/kudu/rpc/rpcz_store.cc
M be/src/kudu/rpc/sasl_common.cc
M be/src/kudu/rpc/sasl_common.h
M be/src/kudu/rpc/sasl_helper.h
M be/src/kudu/rpc/serialization.cc
M be/src/kudu/rpc/serialization.h
M be/src/kudu/rpc/server_negotiation.cc
M be/src/kudu/rpc/service_if.cc
M be/src/kudu/rpc/service_if.h
M be/src/kudu/rpc/service_pool.cc
M be/src/kudu/rpc/service_pool.h
M be/src/kudu/rpc/service_queue.h
M be/src/kudu/rpc/transfer.cc
M be/src/kudu/rpc/transfer.h
M be/src/kudu/security/CMakeLists.txt
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/async_util-test.cc
M be/src/kudu/util/async_util.h
M be/src/kudu/util/bitmap-test.cc
M be/src/kudu/util/bitmap.cc
M be/src/kudu/util/bitmap.h
A be/src/kudu/util/bitset-test.cc
A be/src/kudu/util/bitset.h
A be/src/kudu/util/block_bloom_filter-test.cc
A be/src/kudu/util/block_bloom_filter.cc
A be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter_avx2.cc
R be/src/kudu/util/block_cache_metrics.cc
A be/src/kudu/util/block_cache_metrics.h
M be/src/kudu/util/bloom_filter.h
M be/src/kudu/util/cache-bench.cc
M be/src/kudu/util/cache-test.cc
M be/src/kudu/util/cache.cc
M be/src/kudu/util/cache.h
M be/src/kudu/util/cache_metrics.h
A be/src/kudu/util/char_util-test.cc
A be/src/kudu/util/char_util.cc
A be/src/kudu/util/char_util.h
A be/src/kudu/util/cloud/instance_detector-test.cc
A be/src/kudu/util/cloud/instance_detector.cc
A be/src/kudu/util/cloud/instance_detector.h
A be/src/kudu/util/cloud/instance_metadata.cc
A be/src/kudu/util/cloud/instance_metadata.h
M be/src/kudu/util/compression/compression-test.cc
M be/src/kudu/util/compression/compression_codec.cc
M be/src/kudu/util/countdown_latch-test.cc
M be/src/kudu/util/countdown_latch.h
A be/src/kudu/util/curl_util-test.cc
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
M be/src/kudu/util/debug/trace_event_impl.cc
M be/src/kudu/util/debug/trace_logging.h
M be/src/kudu/util/easy_json.cc
M be/src/kudu/util/env-test.cc
M be/src/kudu/util/env.cc
M be/src/kudu/util/env.h
M be/src/kudu/util/env_posix.cc
M be/src/kudu/util/env_util.cc
M be/src/kudu/util/env_util.h
M be/src/kudu/util/faststring-test.cc
M be/src/kudu/util/faststring.cc
M be/src/kudu/util/faststring.h
M be/src/kudu/util/fault_injection.cc
M be/src/kudu/util/fault_injection.h
M be/src/kudu/util/file_cache-stress-test.cc
M be/src/kudu/util/file_cache-test.cc
M be/src/kudu/util/file_cache.cc
M be/src/kudu/util/file_cache.h
A be/src/kudu/util/file_cache_metrics.cc
A be/src/kudu/util/file_cache_metrics.h
M be/src/kudu/util/flag_tags-test.cc
M be/src/kudu/util/flag_tags.h
M be/src/kudu/util/flags-test.cc
M be/src/kudu/util/flags.cc
M be/src/kudu/util/flags.h
A be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/hdr_histogram-test.cc
M be/src/kudu/util/hdr_histogram.cc
M be/src/kudu/util/hdr_histogram.h
M be/src/kudu/util/high_water_mark.h
M be/src/kudu/util/init.cc
M be/src/kudu/util/init.h
M be/src/kudu/util/int128_util.h
M be/src/kudu/util/interval_tree-inl.h
M be/src/kudu/util/interval_tree-test.cc
M be/src/kudu/util/interval_tree.h
M be/src/kudu/util/jsonreader-test.cc
M be/src/kudu/util/jsonreader.cc
M be/src/kudu/util/jsonreader.h
M be/src/kudu/util/jsonwriter-test.cc
M be/src/kudu/util/jsonwriter.cc
M be/src/kudu/util/jsonwriter.h
D be/src/kudu/util/kudu_export.h
M be/src/kudu/util/logging-test.cc
M be/src/kudu/util/logging.cc
M be/src/kudu/util/logging.h
M be/src/kudu/util/maintenance_manager-test.cc
M be/src/kudu/util/maintenance_manager.cc
M be/src/kudu/util/maintenance_manager.h
M be/src/kudu/util/maintenance_manager.proto
M be/src/kudu/util/map-util-test.cc
M be/src/kudu/util/mem_tracker-test.cc
M be/src/kudu/util/mem_tracker.cc
M be/src/kudu/util/mem_tracker.h
A be/src/kudu/util/mem_tracker.proto
M be/src/kudu/util/metrics-test.cc
M be/src/kudu/util/metrics.cc
M be/src/kudu/util/metrics.h
M be/src/kudu/util/minidump.cc
M be/src/kudu/util/monotime-test.cc
M be/src/kudu/util/monotime.cc
M be/src/kudu/util/monotime.h
M be/src/kudu/util/mt-metrics-test.cc
M be/src/kudu/util/net/dns_resolver-test.cc
M be/src/kudu/util/net/dns_resolver.cc
M be/src/kudu/util/net/dns_resolver.h
M be/src/kudu/util/net/net_util-test.cc
M be/src/kudu/util/net/net_util.cc
M be/src/kudu/util/net/net_util.h
M be/src/kudu/util/net/sockaddr.cc
M be/src/kudu/util/net/sockaddr.h
M be/src/kudu/util/net/socket.cc
M be/src/kudu/util/nvm_cache.cc
M be/src/kudu/util/nvm_cache.h
M be/src/kudu/util/once-test.cc
M be/src/kudu/util/once.cc
M be/src/kudu/util/once.h
M be/src/kudu/util/os-util.cc
M be/src/kudu/util/pb_util-test.cc
M be/src/kudu/util/pb_util.cc
M be/src/kudu/util/pb_util.h
M be/src/kudu/util/process_memory.cc
M be/src/kudu/util/process_memory.h
M be/src/kudu/util/random-test.cc
M be/src/kudu/util/random.h
M be/src/kudu/util/random_util.h
M be/src/kudu/util/rle-encoding.h
M be/src/kudu/util/rle-test.cc
M be/src/kudu/util/rolling_log-test.cc
M be/src/kudu/util/rolling_log.cc
M be/src/kudu/util/rolling_log.h
A be/src/kudu/util/sanitizer_options.cc
M be/src/kudu/util/scoped_cleanup.h
M be/src/kudu/util/signal.cc
M be/src/kudu/util/spinlock_profiling.cc
M be/src/kudu/util/status.cc
M be/src/kudu/util/status.h
M be/src/kudu/util/stopwatch.h
M be/src/kudu/util/string_case.cc
M be/src/kudu/util/string_case.h
M be/src/kudu/util/subprocess-test.cc
M be/src/kudu/util/subprocess.cc
M be/src/kudu/util/subprocess.h
M be/src/kudu/util/test_macros.h
M be/src/kudu/util/test_util.cc
A be/src/kudu/util/testdata/char_truncate_ascii.txt
A be/src/kudu/util/testdata/char_truncate_utf8.txt
M be/src/kudu/util/thread.cc
M be/src/kudu/util/thread.h
M be/src/kudu/util/threadpool-test.cc
M be/src/kudu/util/threadpool.cc
M be/src/kudu/util/threadpool.h
M be/src/kudu/util/trace-test.cc
M be/src/kudu/util/trace.h
A be/src/kudu/util/ttl_cache-test.cc
A be/src/kudu/util/ttl_cache.h
A be/src/kudu/util/ttl_cache_metrics.h
M be/src/kudu/util/user.cc
M be/src/kudu/util/version_util-test.cc
M be/src/kudu/util/version_util.cc
M be/src/kudu/util/version_util.h
A be/src/kudu/util/web_callback_registry.cc
M be/src/kudu/util/web_callback_registry.h
A be/src/kudu/util/yamlreader-test.cc
A be/src/kudu/util/yamlreader.cc
A be/src/kudu/util/yamlreader.h
M be/src/kudu/util/zlib.cc
M be/src/kudu/util/zlib.h
221 files changed, 12,453 insertions(+), 2,954 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/15143/1
--
To view, visit http://gerrit.cloudera.org:8080/15143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9335 (part 1): Rebase copied Kudu source code
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15143 )
Change subject: IMPALA-9335 (part 1): Rebase copied Kudu source code
......................................................................
IMPALA-9335 (part 1): Rebase copied Kudu source code
Removed be/src/kudu/{util|security|rpc} and copied back over from Kudu
commit: fc4ab691a502067bc4d5bdff30507cac7feb7cfe
Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
Reviewed-on: http://gerrit.cloudera.org:8080/15143
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M be/src/kudu/rpc/CMakeLists.txt
M be/src/kudu/rpc/acceptor_pool.cc
M be/src/kudu/rpc/acceptor_pool.h
M be/src/kudu/rpc/blocking_ops.h
M be/src/kudu/rpc/client_negotiation.cc
M be/src/kudu/rpc/connection.cc
M be/src/kudu/rpc/connection.h
M be/src/kudu/rpc/constants.h
M be/src/kudu/rpc/inbound_call.cc
M be/src/kudu/rpc/inbound_call.h
M be/src/kudu/rpc/messenger.cc
M be/src/kudu/rpc/messenger.h
M be/src/kudu/rpc/mt-rpc-test.cc
M be/src/kudu/rpc/negotiation-test.cc
M be/src/kudu/rpc/negotiation.h
M be/src/kudu/rpc/outbound_call.cc
M be/src/kudu/rpc/outbound_call.h
M be/src/kudu/rpc/protoc-gen-krpc.cc
M be/src/kudu/rpc/proxy.h
M be/src/kudu/rpc/reactor.cc
M be/src/kudu/rpc/reactor.h
M be/src/kudu/rpc/remote_method.h
M be/src/kudu/rpc/response_callback.h
M be/src/kudu/rpc/result_tracker.cc
M be/src/kudu/rpc/retriable_rpc.h
M be/src/kudu/rpc/rpc-bench.cc
M be/src/kudu/rpc/rpc-test-base.h
M be/src/kudu/rpc/rpc-test.cc
M be/src/kudu/rpc/rpc.cc
M be/src/kudu/rpc/rpc.h
M be/src/kudu/rpc/rpc_context.cc
M be/src/kudu/rpc/rpc_context.h
M be/src/kudu/rpc/rpc_controller.cc
M be/src/kudu/rpc/rpc_controller.h
M be/src/kudu/rpc/rpc_header.proto
M be/src/kudu/rpc/rpc_introspection.proto
M be/src/kudu/rpc/rpc_service.h
M be/src/kudu/rpc/rpc_sidecar.h
M be/src/kudu/rpc/rpc_stub-test.cc
A be/src/kudu/rpc/rpc_verification_util.cc
A be/src/kudu/rpc/rpc_verification_util.h
M be/src/kudu/rpc/rpcz_store.cc
M be/src/kudu/rpc/sasl_common.cc
M be/src/kudu/rpc/sasl_common.h
M be/src/kudu/rpc/sasl_helper.h
M be/src/kudu/rpc/serialization.cc
M be/src/kudu/rpc/serialization.h
M be/src/kudu/rpc/server_negotiation.cc
M be/src/kudu/rpc/service_if.cc
M be/src/kudu/rpc/service_if.h
M be/src/kudu/rpc/service_pool.cc
M be/src/kudu/rpc/service_pool.h
M be/src/kudu/rpc/service_queue.h
M be/src/kudu/rpc/transfer.cc
M be/src/kudu/rpc/transfer.h
M be/src/kudu/security/CMakeLists.txt
M be/src/kudu/util/CMakeLists.txt
M be/src/kudu/util/async_util-test.cc
M be/src/kudu/util/async_util.h
M be/src/kudu/util/bitmap-test.cc
M be/src/kudu/util/bitmap.cc
M be/src/kudu/util/bitmap.h
A be/src/kudu/util/bitset-test.cc
A be/src/kudu/util/bitset.h
A be/src/kudu/util/block_bloom_filter-test.cc
A be/src/kudu/util/block_bloom_filter.cc
A be/src/kudu/util/block_bloom_filter.h
A be/src/kudu/util/block_bloom_filter_avx2.cc
R be/src/kudu/util/block_cache_metrics.cc
A be/src/kudu/util/block_cache_metrics.h
M be/src/kudu/util/bloom_filter.h
M be/src/kudu/util/cache-bench.cc
M be/src/kudu/util/cache-test.cc
M be/src/kudu/util/cache.cc
M be/src/kudu/util/cache.h
M be/src/kudu/util/cache_metrics.h
A be/src/kudu/util/char_util-test.cc
A be/src/kudu/util/char_util.cc
A be/src/kudu/util/char_util.h
A be/src/kudu/util/cloud/instance_detector-test.cc
A be/src/kudu/util/cloud/instance_detector.cc
A be/src/kudu/util/cloud/instance_detector.h
A be/src/kudu/util/cloud/instance_metadata.cc
A be/src/kudu/util/cloud/instance_metadata.h
M be/src/kudu/util/compression/compression-test.cc
M be/src/kudu/util/compression/compression_codec.cc
M be/src/kudu/util/countdown_latch-test.cc
M be/src/kudu/util/countdown_latch.h
A be/src/kudu/util/curl_util-test.cc
M be/src/kudu/util/curl_util.cc
M be/src/kudu/util/curl_util.h
M be/src/kudu/util/debug/trace_event_impl.cc
M be/src/kudu/util/debug/trace_logging.h
M be/src/kudu/util/easy_json.cc
M be/src/kudu/util/env-test.cc
M be/src/kudu/util/env.cc
M be/src/kudu/util/env.h
M be/src/kudu/util/env_posix.cc
M be/src/kudu/util/env_util.cc
M be/src/kudu/util/env_util.h
M be/src/kudu/util/faststring-test.cc
M be/src/kudu/util/faststring.cc
M be/src/kudu/util/faststring.h
M be/src/kudu/util/fault_injection.cc
M be/src/kudu/util/fault_injection.h
M be/src/kudu/util/file_cache-stress-test.cc
M be/src/kudu/util/file_cache-test.cc
M be/src/kudu/util/file_cache.cc
M be/src/kudu/util/file_cache.h
A be/src/kudu/util/file_cache_metrics.cc
A be/src/kudu/util/file_cache_metrics.h
M be/src/kudu/util/flag_tags-test.cc
M be/src/kudu/util/flag_tags.h
M be/src/kudu/util/flags-test.cc
M be/src/kudu/util/flags.cc
M be/src/kudu/util/flags.h
A be/src/kudu/util/hash.proto
M be/src/kudu/util/hash_util-test.cc
M be/src/kudu/util/hash_util.h
M be/src/kudu/util/hdr_histogram-test.cc
M be/src/kudu/util/hdr_histogram.cc
M be/src/kudu/util/hdr_histogram.h
M be/src/kudu/util/high_water_mark.h
M be/src/kudu/util/init.cc
M be/src/kudu/util/init.h
M be/src/kudu/util/int128_util.h
M be/src/kudu/util/interval_tree-inl.h
M be/src/kudu/util/interval_tree-test.cc
M be/src/kudu/util/interval_tree.h
M be/src/kudu/util/jsonreader-test.cc
M be/src/kudu/util/jsonreader.cc
M be/src/kudu/util/jsonreader.h
M be/src/kudu/util/jsonwriter-test.cc
M be/src/kudu/util/jsonwriter.cc
M be/src/kudu/util/jsonwriter.h
D be/src/kudu/util/kudu_export.h
M be/src/kudu/util/logging-test.cc
M be/src/kudu/util/logging.cc
M be/src/kudu/util/logging.h
M be/src/kudu/util/maintenance_manager-test.cc
M be/src/kudu/util/maintenance_manager.cc
M be/src/kudu/util/maintenance_manager.h
M be/src/kudu/util/maintenance_manager.proto
M be/src/kudu/util/map-util-test.cc
M be/src/kudu/util/mem_tracker-test.cc
M be/src/kudu/util/mem_tracker.cc
M be/src/kudu/util/mem_tracker.h
A be/src/kudu/util/mem_tracker.proto
M be/src/kudu/util/metrics-test.cc
M be/src/kudu/util/metrics.cc
M be/src/kudu/util/metrics.h
M be/src/kudu/util/minidump.cc
M be/src/kudu/util/monotime-test.cc
M be/src/kudu/util/monotime.cc
M be/src/kudu/util/monotime.h
M be/src/kudu/util/mt-metrics-test.cc
M be/src/kudu/util/net/dns_resolver-test.cc
M be/src/kudu/util/net/dns_resolver.cc
M be/src/kudu/util/net/dns_resolver.h
M be/src/kudu/util/net/net_util-test.cc
M be/src/kudu/util/net/net_util.cc
M be/src/kudu/util/net/net_util.h
M be/src/kudu/util/net/sockaddr.cc
M be/src/kudu/util/net/sockaddr.h
M be/src/kudu/util/net/socket.cc
M be/src/kudu/util/nvm_cache.cc
M be/src/kudu/util/nvm_cache.h
M be/src/kudu/util/once-test.cc
M be/src/kudu/util/once.cc
M be/src/kudu/util/once.h
M be/src/kudu/util/os-util.cc
M be/src/kudu/util/pb_util-test.cc
M be/src/kudu/util/pb_util.cc
M be/src/kudu/util/pb_util.h
M be/src/kudu/util/process_memory.cc
M be/src/kudu/util/process_memory.h
M be/src/kudu/util/random-test.cc
M be/src/kudu/util/random.h
M be/src/kudu/util/random_util.h
M be/src/kudu/util/rle-encoding.h
M be/src/kudu/util/rle-test.cc
M be/src/kudu/util/rolling_log-test.cc
M be/src/kudu/util/rolling_log.cc
M be/src/kudu/util/rolling_log.h
A be/src/kudu/util/sanitizer_options.cc
M be/src/kudu/util/scoped_cleanup.h
M be/src/kudu/util/signal.cc
M be/src/kudu/util/spinlock_profiling.cc
M be/src/kudu/util/status.cc
M be/src/kudu/util/status.h
M be/src/kudu/util/stopwatch.h
M be/src/kudu/util/string_case.cc
M be/src/kudu/util/string_case.h
M be/src/kudu/util/subprocess-test.cc
M be/src/kudu/util/subprocess.cc
M be/src/kudu/util/subprocess.h
M be/src/kudu/util/test_macros.h
M be/src/kudu/util/test_util.cc
A be/src/kudu/util/testdata/char_truncate_ascii.txt
A be/src/kudu/util/testdata/char_truncate_utf8.txt
M be/src/kudu/util/thread.cc
M be/src/kudu/util/thread.h
M be/src/kudu/util/threadpool-test.cc
M be/src/kudu/util/threadpool.cc
M be/src/kudu/util/threadpool.h
M be/src/kudu/util/trace-test.cc
M be/src/kudu/util/trace.h
A be/src/kudu/util/ttl_cache-test.cc
A be/src/kudu/util/ttl_cache.h
A be/src/kudu/util/ttl_cache_metrics.h
M be/src/kudu/util/user.cc
M be/src/kudu/util/version_util-test.cc
M be/src/kudu/util/version_util.cc
M be/src/kudu/util/version_util.h
A be/src/kudu/util/web_callback_registry.cc
M be/src/kudu/util/web_callback_registry.h
A be/src/kudu/util/yamlreader-test.cc
A be/src/kudu/util/yamlreader.cc
A be/src/kudu/util/yamlreader.h
M be/src/kudu/util/zlib.cc
M be/src/kudu/util/zlib.h
221 files changed, 12,453 insertions(+), 2,954 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Thomas Tauber-Marshall: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9335 (part 1): Rebase copied Kudu source code
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15143 )
Change subject: IMPALA-9335 (part 1): Rebase copied Kudu source code
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 23:03:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 1): Rebase copied Kudu source code
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15143 )
Change subject: IMPALA-9335 (part 1): Rebase copied Kudu source code
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5569/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Fri, 31 Jan 2020 17:01:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9335 (part 1): Rebase copied Kudu source code
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15143 )
Change subject: IMPALA-9335 (part 1): Rebase copied Kudu source code
......................................................................
Patch Set 1: Code-Review+2
Looks good.
(Checked out kudu at that commit and compared the files in be/src/kudu to the corresponding files in kudu.)
--
To view, visit http://gerrit.cloudera.org:8080/15143
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0190f15b96563f5edc40065fa4690c467c50f83
Gerrit-Change-Number: 15143
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Feb 2020 17:31:34 +0000
Gerrit-HasComments: No