You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/31 02:37:09 UTC

[GitHub] [inlong] gosonzhang opened a new issue, #5748: [Improve][TubeMQ] Remove the virtual keyword of the destructor of the TubeMQTDMsg and DataItem classes

gosonzhang opened a new issue, #5748:
URL: https://github.com/apache/inlong/issues/5748

   ### Description
   
   The destructors of the TubeMQTDMsg and DataItem classes carry the virtual keyword, which is easy for users to mistakenly think that they have subclasses. In fact, they are just a wrapper class for message content, and it is not recommended for users to use them as parent classes and then derive subclasses. In order to avoid misuse, the virtual keyword of the destructors of these two classes is removed here:
   ![image](https://user-images.githubusercontent.com/14038849/187580228-158f6812-cca5-48d3-894c-7e7ded5f0638.png)
   
   
   ### InLong Component
   
   InLong TubeMQ
   
   ### Are you willing to submit PR?
   
   - [X] Yes, I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang closed issue #5748: [Improve][TubeMQ] Remove the virtual keyword of the destructor of the TubeMQTDMsg and DataItem classes

Posted by GitBox <gi...@apache.org>.
dockerzhang closed issue #5748: [Improve][TubeMQ] Remove the virtual keyword of the destructor of the TubeMQTDMsg and DataItem classes
URL: https://github.com/apache/inlong/issues/5748


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org