You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/15 05:20:40 UTC
[kudu-CR] webserver-test: refactoring and simplification
Hello Alexey Serbin, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14438
to review the following change.
Change subject: webserver-test: refactoring and simplification
......................................................................
webserver-test: refactoring and simplification
Change-Id: I1ba2e1bcc177b7f209562dd6e9c80043ebb9099d
---
M src/kudu/server/webserver-test.cc
1 file changed, 39 insertions(+), 62 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/14438/1
--
To view, visit http://gerrit.cloudera.org:8080/14438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ba2e1bcc177b7f209562dd6e9c80043ebb9099d
Gerrit-Change-Number: 14438
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] webserver-test: refactoring and simplification
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14438 )
Change subject: webserver-test: refactoring and simplification
......................................................................
webserver-test: refactoring and simplification
Change-Id: I1ba2e1bcc177b7f209562dd6e9c80043ebb9099d
Reviewed-on: http://gerrit.cloudera.org:8080/14438
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/server/webserver-test.cc
1 file changed, 39 insertions(+), 62 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ba2e1bcc177b7f209562dd6e9c80043ebb9099d
Gerrit-Change-Number: 14438
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] webserver-test: refactoring and simplification
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14438 )
Change subject: webserver-test: refactoring and simplification
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14438
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ba2e1bcc177b7f209562dd6e9c80043ebb9099d
Gerrit-Change-Number: 14438
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 15 Oct 2019 05:27:13 +0000
Gerrit-HasComments: No