[GitHub] [lucene-solr] anshumg commented on a change in pull request #2355: SOLR-15145: solr.storeBaseUrl feature flag introduced in 8.8.1 should default to false for 9.x

[GitBox <gi...@apache.org>]

anshumg commented on a change in pull request #2355:
URL: https://github.com/apache/lucene-solr/pull/2355#discussion_r574731370



##########
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##########
@@ -100,6 +100,12 @@ The default Prometheus Exporter configuration includes metrics like queries-per-
 Plugin developers using `SolrPaths.locateSolrHome()` or 'new `SolrResourceLoader`' should check deprecation warnings as existing some existing functionality will be removed in 9.0.
 https://issues.apache.org/jira/browse/SOLR-14934[SOLR-14934] has more technical details about this change for those concerned.
 
+*Removing base_url from Stored State*
+
+If you're able to upgrade SolrJ to 8.8.x for all of your client applications, then you can set `-Dsolr.storeBaseUrl=false` (introduced in Solr 8.8.1)
+to better align the stored state in Zookeeper with future versions of Solr. However, if you are not able to upgrade SolrJ to 8.8.x for all client applications, then
+leave the default `-Dsolr.storeBaseUrl=true` so that Solr will continue to store the `base_url` in Zookeeper.

Review comment:
       Perhaps add a note about this going away completely in the next major release? It's obvious for the folks who know but would be good to highlight for newer users or people who've inherited old systems. 

##########
File path: solr/CHANGES.txt
##########
@@ -238,13 +238,21 @@ Bug Fixes
 ---------------------
 * SOLR-15078: Fix ExpandComponent behavior when expanding on numeric fields to differentiate '0' group from null group (hossman)
 
-* SOLR-15114: Fix bug that caused WAND optimization to be disabled in cases where the max score is requested (such as

Review comment:
       👍🏽 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org