You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/21 10:39:07 UTC
[GitHub] [netbeans] entlicher opened a new pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
entlicher opened a new pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697
Adapted to work with multiple threads, all necessary views are provided, functionality improved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#issuecomment-764731763
@entlicher this just reminded while you're looking at CPPLite debugger for 12.3, is it at all possible to change the external dependency name to remove `SNAPSHOT`? It stops this cluster being included in the Maven publishing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#issuecomment-764790431
@neilcsmith-net O.K. I'll do that...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#issuecomment-764731763
@entlicher this just reminded while you're looking at CPPLite debugger for 12.3, is it at all possible to change the external dependency name to remove `SNAPSHOT`? It stops this cluster being included in the Maven publishing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on a change in pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#discussion_r561970871
##########
File path: cpplite/cpplite.debugger/test/unit/src/org/netbeans/modules/cpplite/debugger/StepTest.java
##########
@@ -75,7 +75,7 @@ public void testStepOver () throws Exception {
LineCookie lc = DataObject.find(source).getLookup().lookup(LineCookie.class);
assertNotNull(lc);
DebuggerManager.getDebuggerManager().addBreakpoint(new CPPLiteBreakpoint(lc.getLineSet().getCurrent(4)));
- CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()))).first();
+ CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()), wd)).first();
Review comment:
Right. I plan to improve the tests, hopefully soon after the 12.3 feature-freeze.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on a change in pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher commented on a change in pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#discussion_r561970871
##########
File path: cpplite/cpplite.debugger/test/unit/src/org/netbeans/modules/cpplite/debugger/StepTest.java
##########
@@ -75,7 +75,7 @@ public void testStepOver () throws Exception {
LineCookie lc = DataObject.find(source).getLookup().lookup(LineCookie.class);
assertNotNull(lc);
DebuggerManager.getDebuggerManager().addBreakpoint(new CPPLiteBreakpoint(lc.getLineSet().getCurrent(4)));
- CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()))).first();
+ CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()), wd)).first();
Review comment:
Right. I plan to improve the tests, hopefully soon after the 12.3 feature-freeze.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher merged pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher merged pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#issuecomment-764790431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#discussion_r561855988
##########
File path: cpplite/cpplite.debugger/test/unit/src/org/netbeans/modules/cpplite/debugger/StepTest.java
##########
@@ -75,7 +75,7 @@ public void testStepOver () throws Exception {
LineCookie lc = DataObject.find(source).getLookup().lookup(LineCookie.class);
assertNotNull(lc);
DebuggerManager.getDebuggerManager().addBreakpoint(new CPPLiteBreakpoint(lc.getLineSet().getCurrent(4)));
- CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()))).first();
+ CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()), wd)).first();
Review comment:
I guess this test could be expanded to cover bits of the new functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#discussion_r561855988
##########
File path: cpplite/cpplite.debugger/test/unit/src/org/netbeans/modules/cpplite/debugger/StepTest.java
##########
@@ -75,7 +75,7 @@ public void testStepOver () throws Exception {
LineCookie lc = DataObject.find(source).getLookup().lookup(LineCookie.class);
assertNotNull(lc);
DebuggerManager.getDebuggerManager().addBreakpoint(new CPPLiteBreakpoint(lc.getLineSet().getCurrent(4)));
- CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()))).first();
+ CPPLiteDebugger d = CPPLiteDebugger.startDebugging(new CPPLiteDebuggerConfig(Arrays.asList(new File(wd, "main").getAbsolutePath()), wd)).first();
Review comment:
I guess this test could be expanded to cover bits of the new functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] entlicher commented on pull request #2697: Completing the CPPLite debugger: threads, variables, watches, tooltips, etc...
Posted by GitBox <gi...@apache.org>.
entlicher commented on pull request #2697:
URL: https://github.com/apache/netbeans/pull/2697#issuecomment-765074409
@neilcsmith-net Well, the file in question is in binaries: `cpplite-mi-1.0-SNAPSHOT.jar`. It's not anything from Maven. However, I didn't find that file at http://netbeans.osuosl.org/binaries/ I'd rather solve this in a separate PR given the approaching feature freeze.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists