You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vishal Suvagia via Review Board <no...@reviews.apache.org> on 2017/05/04 15:16:14 UTC
Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932
Repository: ambari
Description
-------
Add support to enable Ranger Nifi plugin.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
Diff: https://reviews.apache.org/r/58995/diff/1/
Testing
-------
Verified fresh installation on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review174056
-----------------------------------------------------------
Fix it, then Ship it!
Fix it and ship it
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
Line 52 (original), 52 (patched)
<https://reviews.apache.org/r/58995/#comment247162>
Nitpick, add some spaces after the comma
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
Line 217 (original), 216 (patched)
<https://reviews.apache.org/r/58995/#comment247161>
Change this to
if cred_lib_path_override is not None:
cred_lib_path = cred_lib_path_override
else:
cred_lib_path = format('{stack_root}/{stack_version}/ranger-{service_name}-plugin/install/lib/*')
- Alejandro Fernandez
On May 5, 2017, 1:44 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> -----------------------------------------------------------
>
> (Updated May 5, 2017, 1:44 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support to enable Ranger Nifi plugin.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
>
>
> Diff: https://reviews.apache.org/r/58995/diff/2/
>
>
> Testing
> -------
>
> Verified fresh installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review174139
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On May 6, 2017, 6:45 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> -----------------------------------------------------------
>
> (Updated May 6, 2017, 6:45 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support to enable Ranger Nifi plugin.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
>
>
> Diff: https://reviews.apache.org/r/58995/diff/3/
>
>
> Testing
> -------
>
> Verified fresh installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
-----------------------------------------------------------
(Updated May 6, 2017, 6:45 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
Changes
-------
Updated patch to address review comments.
Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932
Repository: ambari
Description
-------
Add support to enable Ranger Nifi plugin.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
Diff: https://reviews.apache.org/r/58995/diff/3/
Changes: https://reviews.apache.org/r/58995/diff/2-3/
Testing
-------
Verified fresh installation on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/
-----------------------------------------------------------
(Updated May 5, 2017, 1:44 p.m.)
Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
Changes
-------
Updated patch to remove hardcoding of stack checks.
Bugs: AMBARI-20932
https://issues.apache.org/jira/browse/AMBARI-20932
Repository: ambari
Description
-------
Add support to enable Ranger Nifi plugin.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
Diff: https://reviews.apache.org/r/58995/diff/2/
Changes: https://reviews.apache.org/r/58995/diff/1-2/
Testing
-------
Verified fresh installation on Cent-OS 6.
Thanks,
Vishal Suvagia
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Vishal Suvagia via Review Board <no...@reviews.apache.org>.
> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > <https://reviews.apache.org/r/58995/diff/1/?file=1708375#file1708375line221>
> >
> > We should use stack_root and avoid harcoding HDP or HDF.
Hi Alejandro,
As Nifi will be an HDP add-on service, and bits for Nifi will be installed under path /usr/hdf/{stack-version} from HDF repos even in an HDP stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will need to keep the stack-checks.
- Vishal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
-----------------------------------------------------------
On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 3:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support to enable Ranger Nifi plugin.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
>
>
> Diff: https://reviews.apache.org/r/58995/diff/1/
>
>
> Testing
> -------
>
> Verified fresh installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On May 4, 2017, 7:48 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
> > Lines 221 (patched)
> > <https://reviews.apache.org/r/58995/diff/1/?file=1708375#file1708375line221>
> >
> > We should use stack_root and avoid harcoding HDP or HDF.
>
> Vishal Suvagia wrote:
> Hi Alejandro,
> As Nifi will be an HDP add-on service, and bits for Nifi will be installed under path /usr/hdf/{stack-version} from HDF repos even in an HDP stack cluster. So to differentiate between HDF(for Nifi) and HDP, we will need to keep the stack-checks.
Can you pass cred_lib_path_override and cred_setup_prefix_override parameters to this function and in NIFI pass these parameters explicit;y. That way we can get rid of both the hardcodings.
if service_name == 'nifi':
AND
if stack_name == 'HDP':
Let NIFI explicitly handle this in their service definition and pass in the override parameters, instead of the utility function in resource_management library having these hardcodings.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
-----------------------------------------------------------
On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 3:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support to enable Ranger Nifi plugin.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
>
>
> Diff: https://reviews.apache.org/r/58995/diff/1/
>
>
> Testing
> -------
>
> Verified fresh installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>
Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should
handle Nifi service
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58995/#review173950
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
Lines 221 (patched)
<https://reviews.apache.org/r/58995/#comment247019>
We should use stack_root and avoid harcoding HDP or HDF.
- Alejandro Fernandez
On May 4, 2017, 3:16 p.m., Vishal Suvagia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58995/
> -----------------------------------------------------------
>
> (Updated May 4, 2017, 3:16 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, Mugdha Varadkar, Sumit Mohanty, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-20932
> https://issues.apache.org/jira/browse/AMBARI-20932
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support to enable Ranger Nifi plugin.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py c510dac
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-env.xml 661089a
> ambari-server/src/main/resources/common-services/RANGER/0.7.0/themes/theme_version_5.json 87fccbe
>
>
> Diff: https://reviews.apache.org/r/58995/diff/1/
>
>
> Testing
> -------
>
> Verified fresh installation on Cent-OS 6.
>
>
> Thanks,
>
> Vishal Suvagia
>
>