[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #7236: GEODE-9829: Add SINTER command to Redis supported commands.

[GitBox <gi...@apache.org>]

nonbinaryprogrammer commented on a change in pull request #7236:
URL: https://github.com/apache/geode/pull/7236#discussion_r780466710



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -110,6 +111,42 @@ private static MemberSet calculateDiff(RegionProvider regionProvider, List<Redis
     return diff;
   }
 
+  public static Set<byte[]> sinter(RegionProvider regionProvider, List<RedisKey> keys) {
+    List<RedisSet> sets = new ArrayList<>(keys.size());
+    RedisSet smallestSet = NULL_REDIS_SET;
+
+    for (RedisKey key : keys) {
+      RedisSet redisSet = regionProvider.getTypedRedisData(REDIS_SET, key, true);
+      if (redisSet == NULL_REDIS_SET) {
+        return Collections.emptySet();
+      }
+      if (smallestSet == NULL_REDIS_SET) {
+        smallestSet = redisSet;
+      }
+      if (smallestSet.scard() > redisSet.scard()) {
+        sets.add(smallestSet);
+        smallestSet = redisSet;
+      } else {
+        sets.add(redisSet);
+      }
+    }
+
+    MemberSet result = new MemberSet(smallestSet.scard());
+    for (byte[] member : smallestSet.members) {
+      boolean addToSet = true;
+      for (RedisSet otherSet : sets) {
+        if (!otherSet.members.contains(member)) {
+          addToSet = false;
+          break;
+        }
+      }
+      if (addToSet) {
+        result.add(member);
+      }

Review comment:
       not a big deal, but this can be simplified to
   ```
   for(RedisSet otherSet : sets) {
       if(otherSet.members.contains(member)) {
           result.add(member);
       } else {
           break;
       }
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org