You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Raúl Cumplido (Jira)" <ji...@apache.org> on 2022/04/13 11:08:00 UTC

[jira] [Commented] (ARROW-16062) [Python] Move libarrow_python include definitions to their own file

    [ https://issues.apache.org/jira/browse/ARROW-16062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521618#comment-17521618 ] 

Raúl Cumplido commented on ARROW-16062:
---------------------------------------

[~apitrou]  I have created the following draft PR: [https://github.com/apache/arrow/pull/12873] I just wanted to validate with you this is in line with what you were looking for on this ticket.

I still have to go around the _nogil_ declarations

> [Python] Move libarrow_python include definitions to their own file
> -------------------------------------------------------------------
>
>                 Key: ARROW-16062
>                 URL: https://issues.apache.org/jira/browse/ARROW-16062
>             Project: Apache Arrow
>          Issue Type: Task
>          Components: Python
>            Reporter: Antoine Pitrou
>            Assignee: Raúl Cumplido
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 8.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the API declarations for {{libarrow_python.so}} are in {{libarrow.pxd}} together with the {{libarrow.so}} inclusions. It would probably make more sense to move them to a {{libarrow_python.pxd}} file.
> Also, it seems some {{nogil}} declarations must be fixed for those APIs that actually take/return a {{PyObject*}}, or depend on Python C APIs.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)