You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "nsivabalan (via GitHub)" <gi...@apache.org> on 2023/03/13 16:45:11 UTC
[GitHub] [hudi] nsivabalan opened a new pull request, #8169: [HUDI-5924] Fixing cli clean command to trim down a subset based on start and end
nsivabalan opened a new pull request, #8169:
URL: https://github.com/apache/hudi/pull/8169
### Change Logs
Adding support to trim the timeline for hudi cli clean command. Also added option to load from archive timeline.
### Impact
More usable cli for inspecting clean commits
### Risk level (write none, low medium or high below)
low
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8169: [HUDI-5924] Fixing cli clean command to trim down a subset based on start and end
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8169:
URL: https://github.com/apache/hudi/pull/8169#issuecomment-1466606184
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d9c4e12c3215cc02f35f66809fdf22aef2d84890",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15694",
"triggerID" : "d9c4e12c3215cc02f35f66809fdf22aef2d84890",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9c4e12c3215cc02f35f66809fdf22aef2d84890 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15694)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8169: [HUDI-5924] Fixing cli clean command to trim down a subset based on start and end
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8169:
URL: https://github.com/apache/hudi/pull/8169#issuecomment-1466987381
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d9c4e12c3215cc02f35f66809fdf22aef2d84890",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15694",
"triggerID" : "d9c4e12c3215cc02f35f66809fdf22aef2d84890",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9c4e12c3215cc02f35f66809fdf22aef2d84890 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15694)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8169: [HUDI-5924] Fixing cli clean command to trim down a subset based on start and end
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8169:
URL: https://github.com/apache/hudi/pull/8169#issuecomment-1466595471
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d9c4e12c3215cc02f35f66809fdf22aef2d84890",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d9c4e12c3215cc02f35f66809fdf22aef2d84890",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d9c4e12c3215cc02f35f66809fdf22aef2d84890 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8169: [HUDI-5924] Fixing cli clean command to trim down a subset based on start and end
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8169:
URL: https://github.com/apache/hudi/pull/8169#discussion_r1335093529
##########
hudi-cli/src/main/java/org/apache/hudi/cli/utils/CLIUtils.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.cli.utils;
+
+import org.apache.hudi.cli.HoodieCLI;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.timeline.HoodieActiveTimeline;
+import org.apache.hudi.common.table.timeline.HoodieArchivedTimeline;
+import org.apache.hudi.common.table.timeline.HoodieDefaultTimeline;
+
+import static org.apache.hudi.cli.utils.CommitUtil.getTimeDaysAgo;
+import static org.apache.hudi.common.util.StringUtils.isNullOrEmpty;
+import static org.apache.hudi.common.util.StringUtils.nonEmpty;
+import static org.apache.hudi.common.util.ValidationUtils.checkArgument;
+
+/**
+ * Utils class for cli commands.
+ */
+public class CLIUtils {
+
+ public static HoodieDefaultTimeline getTimelineInRange(String startTs, String endTs, boolean includeArchivedTimeline) {
Review Comment:
nit: Javadocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #8169: [HUDI-5924] Fixing cli clean command to trim down a subset based on start and end
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8169:
URL: https://github.com/apache/hudi/pull/8169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org