You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/08 12:57:02 UTC

[GitHub] [incubator-seatunnel] ic4y opened a new pull request, #2687: [ST-Engine][Api] Replace SeaTunnelContext with JobContext and remove singleton pattern

ic4y opened a new pull request, #2687:
URL: https://github.com/apache/incubator-seatunnel/pull/2687

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   Since the new engine can run multiple jobs at the same time, the `SeaTunnelContext` of the previous singleton pattern mode is not applicable and will cause bugs, because each job needs to hold a `SeaTunnelContext`.
   so replace `SeaTunnelContext` with `JobContext` and remove singleton pattern.
   
   
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ic4y closed pull request #2687: [ST-Engine][Api] Replace SeaTunnelContext with JobContext and remove singleton pattern

Posted by GitBox <gi...@apache.org>.
ic4y closed pull request #2687: [ST-Engine][Api] Replace SeaTunnelContext with JobContext and remove singleton pattern
URL: https://github.com/apache/incubator-seatunnel/pull/2687


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ic4y commented on pull request #2687: [ST-Engine][Api] Replace SeaTunnelContext with JobContext and remove singleton pattern

Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2687:
URL: https://github.com/apache/incubator-seatunnel/pull/2687#issuecomment-1241511825

   > Hi, could you submit this change to dev branch first?
   
   yes i am doing this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2687: [ST-Engine][Api] Replace SeaTunnelContext with JobContext and remove singleton pattern

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2687:
URL: https://github.com/apache/incubator-seatunnel/pull/2687#issuecomment-1241504646

   Hi, could you submit this change to dev branch first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org