You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/25 08:26:30 UTC

[GitHub] [superset] stevensuting opened a new issue #16438: Native filter issue when upgrading from 1.1 to 1.3

stevensuting opened a new issue #16438:
URL: https://github.com/apache/superset/issues/16438


   When upgrading from 1.1 to 1.3, dashboards that use Native filter are unusable.
   <img width="400" alt="Screenshot 2021-08-24 at 9 43 56 PM" src="https://user-images.githubusercontent.com/8875448/130755284-59c16af7-96f6-4bd4-96c2-48c0fb7eaf68.png">
   
   On clicking see more:
   <img width="592" alt="Native filters 1 1 to 1 3 upgrade" src="https://user-images.githubusercontent.com/8875448/130755097-5c4a3f8f-97ec-494e-9ad0-f63b46e3eecc.png">
   
   ### Expected results
   The upgrade should not disrupt the filters.
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `1.3`
   - python version: `3.9`
   - installed via pip install.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #16438: Native filter issue when upgrading from 1.1 to 1.3

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16438:
URL: https://github.com/apache/superset/issues/16438#issuecomment-906072656


   Thanks for reporting @stevensuting ! We will look what it would take to fix this for 1.3.1!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro closed issue #16438: [native filter]select filter on dashboard with NULL values fails

Posted by GitBox <gi...@apache.org>.
villebro closed issue #16438:
URL: https://github.com/apache/superset/issues/16438


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #16438: [native filter]select filter on dashboard with NULL values fails

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16438:
URL: https://github.com/apache/superset/issues/16438#issuecomment-908299829


   I can confirmed that #16468 fixes this (falls back to defaults for filter-specific control values):
   
   ### BEFORE
   ![image](https://user-images.githubusercontent.com/33317356/131338549-94608e9b-4701-45a2-91ab-b22f34282567.png)
   
   ### AFTER
   ![image](https://user-images.githubusercontent.com/33317356/131338609-5653b3a2-353a-468a-8c79-f61f802d5aff.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #16438: Native filter issue when upgrading from 1.1 to 1.3

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16438:
URL: https://github.com/apache/superset/issues/16438#issuecomment-906073567


   @stevensuting I'm looking for minimal reproduction steps for this bug. Does this sound accurate?
   - Spin up a 1.1 version of Superset
   - Create a select filter on a dashboard
   - Upgrade to 1.3
   - Go into dashboard that was created with 1.1
   - See error message
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #16438: Native filter issue when upgrading from 1.1 to 1.3

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16438:
URL: https://github.com/apache/superset/issues/16438#issuecomment-906538485


   @villebro @jinghua-qa i think we should test version upgrade to make sure not only the new version works, but also a smooth upgrade from an older version. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org