You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "David S. Wang (JIRA)" <ji...@apache.org> on 2012/04/30 17:45:50 UTC
[jira] [Created] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
David S. Wang created HBASE-5904:
------------------------------------
Summary: is_enabled from shell returns differently from pre- and post- HBASE-5155
Key: HBASE-5904
URL: https://issues.apache.org/jira/browse/HBASE-5904
Project: HBase
Issue Type: Bug
Components: zookeeper
Affects Versions: 0.90.6
Reporter: David S. Wang
If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274084#comment-13274084 ]
stack commented on HBASE-5904:
------------------------------
@Ram As I read it above, we are about backing out hbase-5155 Thats what your patch does David? If so, I'm +1 on applying it to 0.90.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266120#comment-13266120 ]
stack commented on HBASE-5904:
------------------------------
@David Ignore my query over in hbase-5155. I should probably run a 0.90.7 once it goes in...
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265047#comment-13265047 ]
stack commented on HBASE-5904:
------------------------------
I suppose it would make sense backing it out. We could roll a 0.90.7?
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401105#comment-13401105 ]
Jonathan Hsieh commented on HBASE-5904:
---------------------------------------
Tests pass. Will commit tomorrow.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5904:
---------------------------------
Assignee: David S. Wang
Status: Patch Available (was: Open)
Revert HBASE-5155. Should apply only to 0.90 branch.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5904:
---------------------------------
Attachment: HBASE-5904.patch
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-5904:
----------------------------------
Resolution: Fixed
Release Note: This reverts a patch included in 0.90.6 that broke compatibility.
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks for the patch Dave, Thanks for reviews Stack and Ram.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5904:
-------------------------
Priority: Blocker (was: Major)
Fix Version/s: 0.90.7
Making this a blocker on 0.90.7 so we don't forget it.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264990#comment-13264990 ]
stack commented on HBASE-5904:
------------------------------
Then we should revert hbase-5155, would you agree David?
IIRC, there was a reason for absence of znode meaning ENABLED but don't remember it off hand.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264994#comment-13264994 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
Also, I'm not sure if it matters that 0.90.6 was already cut with this change. That means that there is already an incompatible release out there. I do not know what the precedent is here or if there is one.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5904:
---------------------------------
Attachment: HBASE-5904.patch
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272084#comment-13272084 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
I thought that was what we agreed upon earlier. At least that is the impression that I got from reading the earlier comments.
Do you think there is a way to keep the part of the patch with the actual fix, without having the incompatible ZK behavior?
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269811#comment-13269811 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
I added a patch off of 0.90 to revert HBASE-5155. I'll throw this on RB as well, but wanted to kick off Hadoop QA bot now. Note that all unit tests for me except for org.apache.hadoop.hbase.TestZooKeeper.testClientSessionExpired, which fails fairly consistently with or without this change.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272079#comment-13272079 ]
ramkrishna.s.vasudevan commented on HBASE-5904:
-----------------------------------------------
@David
I saw your patch at a glance. So this patch will not address HBASE-5155?
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274101#comment-13274101 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
Stack: That (backing out HBASE-5155 only) is what my patch does.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265022#comment-13265022 ]
ramkrishna.s.vasudevan commented on HBASE-5904:
-----------------------------------------------
Added release note to HBASE-5155.
@David/@Stack
Please take a look at it.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264992#comment-13264992 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
I think at least a partial revert of HBASE-5155 is warranted here. I don't know if we want to back it out entirely as it seems to solve a race condition that would be good to not have. Perhaps most of the patch can remain, but the part that handles how a table is represented as enabled in ZK can be reverted or worked around. But Ram can comment further on how best to handle this.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265024#comment-13265024 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
Should we back out HBASE-5155 entirely for now? I looked at it and just backing out the part that changes the znode behavior implies that we should also remove isTablePresent(), which seems to affect more of the patch's functionality and then it gets messy.
Is there any later change that depends on HBASE-5155?
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264999#comment-13264999 ]
ramkrishna.s.vasudevan commented on HBASE-5904:
-----------------------------------------------
@Stack
Yes, David discussed this with me too. But i was also not sure as how to go about with this. Thanks David for bringing this up.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401173#comment-13401173 ]
ramkrishna.s.vasudevan commented on HBASE-5904:
-----------------------------------------------
+1.
@Stack
bq.Let us know if you have issue w/ that.
No problem.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401019#comment-13401019 ]
Jonathan Hsieh commented on HBASE-5904:
---------------------------------------
I'm testing this patch currently (which is a revert of HBASE-5155) and plan on committing for 0.90.7 if it is clean unless I hear any complaints.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279279#comment-13279279 ]
stack commented on HBASE-5904:
------------------------------
@Ram I will apply David's patch that backs hbase-5155 out of 0.90 tomorrow. Let us know if you have issue w/ that.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Priority: Blocker
> Fix For: 0.90.7
>
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271950#comment-13271950 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
The patch did not apply because it's against 0.90, which it seems always fails with the QA robot.
Anyone care to take a stab at the review? I thought it was a fairly straightforward revert.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5904:
---------------------------------
Attachment: (was: HBASE-5904.patch)
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269854#comment-13269854 ]
Hadoop QA commented on HBASE-5904:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525885/HBASE-5904.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1791//console
This message is automatically generated.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5904.patch
>
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265079#comment-13265079 ]
David S. Wang commented on HBASE-5904:
--------------------------------------
I have a patch to back it out and will post it once I have test it more. The patch seems to make things compatible again but I want to make sure it doesn't break anything else. Look for it in a day or two.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5904) is_enabled from shell returns
differently from pre- and post- HBASE-5155
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265005#comment-13265005 ]
stack commented on HBASE-5904:
------------------------------
If 0.90.6 has this breakage, then the damage is done. We should mark hbase-5155 an incompatible change and put in a fat release note w/ how it changes behavior (Steal some of David's notes above). You up for doing this Ram?
I'm surprised that the change in semantic where no znode no longer means enabled has not caused other issues.
Good digging David.
> is_enabled from shell returns differently from pre- and post- HBASE-5155
> ------------------------------------------------------------------------
>
> Key: HBASE-5904
> URL: https://issues.apache.org/jira/browse/HBASE-5904
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.6
> Reporter: David S. Wang
>
> If I launch an hbase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers with HBASE-5155, then is_enabled for a table always returns false even if the table is considered enabled by the servers from the logs. If I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns as expected.
> If I launch an HBase shell that uses HBase and ZooKeeper without HBASE-5155, against HBase servers also without HBASE-5155, then is_enabled works as you'd expect. But if I then do the same thing but with an HBase shell and ZooKeeper with HBASE-5155, then is_enabled returns false even though the table is considered enabled by the servers from the logs.
> Additionally, if I then try to enable the table from the HBASE-5155-containing shell, it hangs because the ZooKeeper code waits for the ZNode to be updated with "ENABLED" in the data field, but what actually happens is that the ZNode gets deleted since the servers are running without HBASE-5155.
> I think the culprit is that the indication of how a table is considered enabled inside ZooKeeper has changed with HBASE-5155. Before HBASE-5155, a table was considered enabled if the ZNode for it did not exist. After HBASE-5155, a table is considered enabled if the ZNode for it exists and has "ENABLED" in its data. I think the current code is incompatible when running clients and servers where one side has HBASE-5155 and the other side does not.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira