You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2015/11/16 22:51:48 UTC
Review Request 40370: AMBARI-13913. Express Upgrade: didn't finalize
HDFS, improve robustness for HA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40370/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-13913
https://issues.apache.org/jira/browse/AMBARI-13913
Repository: ambari
Description
-------
For Express Upgrade,
1. We started the NameNodes with "-rollingUpgrade started" but were calling the wrong finalize command, "-finalizeUpgrade" instead of "-rollingUpgrade finalize".
2. In HA, if safemode was already on, then the prepare step would fail since the grep command reported an error.
3. In HA, we now check both NameNodes to come out of safemode. Before, this would only run on the active one.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 1fada76
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py f8a327f
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml efc3753
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml fa69e72
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 6282fdc
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 798c895
Diff: https://reviews.apache.org/r/40370/diff/
Testing
-------
Tested this during Express Upgrade.
HDP 2.1->2.3.0.0->2.3.2.0 and finalize
HDP 2.2->2.3.0.0->2.3.2.0 and downgrade on the last item.
Python unit tests passed.
----------------------------------------------------------------------
Total run:828
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 40370: AMBARI-13913. Express Upgrade: didn't
finalize HDFS, improve robustness for HA
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On Nov. 16, 2015, 10:09 p.m., Jonathan Hurley wrote:
> > So this command change is only for express? It stays the way it is in rolling?
Correct
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40370/#review106745
-----------------------------------------------------------
On Nov. 16, 2015, 9:59 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40370/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:59 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13913
> https://issues.apache.org/jira/browse/AMBARI-13913
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Express Upgrade,
>
> 1. We started the NameNodes with "-rollingUpgrade started" but were calling the wrong finalize command, "-finalizeUpgrade" instead of "-rollingUpgrade finalize".
> 2. In HA, if safemode was already on, then the prepare step would fail since the grep command reported an error.
> 3. In HA, we now check both NameNodes to come out of safemode. Before, this would only run on the active one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 1fada76
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py f8a327f
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml efc3753
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml fa69e72
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 6282fdc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 798c895
>
> Diff: https://reviews.apache.org/r/40370/diff/
>
>
> Testing
> -------
>
> Tested this during Express Upgrade.
>
> HDP 2.1 with NameNode HA, then Express Upgrades 2.1->2.3.0.0->2.3.2.0 and finalize
> HDP without NameNode HA, and then Express Upgrades 2.2->2.3.0.0->2.3.2.0 and downgrade on the last item.
>
> Python unit tests passed.
> ----------------------------------------------------------------------
> Total run:828
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40370: AMBARI-13913. Express Upgrade: didn't
finalize HDFS, improve robustness for HA
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40370/#review106745
-----------------------------------------------------------
Ship it!
So this command change is only for express? It stays the way it is in rolling?
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml (line 298)
<https://reviews.apache.org/r/40370/#comment165504>
"all" is the default here; you don't technically need to set it.
- Jonathan Hurley
On Nov. 16, 2015, 4:59 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40370/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 4:59 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13913
> https://issues.apache.org/jira/browse/AMBARI-13913
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Express Upgrade,
>
> 1. We started the NameNodes with "-rollingUpgrade started" but were calling the wrong finalize command, "-finalizeUpgrade" instead of "-rollingUpgrade finalize".
> 2. In HA, if safemode was already on, then the prepare step would fail since the grep command reported an error.
> 3. In HA, we now check both NameNodes to come out of safemode. Before, this would only run on the active one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 1fada76
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py f8a327f
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml efc3753
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml fa69e72
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 6282fdc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 798c895
>
> Diff: https://reviews.apache.org/r/40370/diff/
>
>
> Testing
> -------
>
> Tested this during Express Upgrade.
>
> HDP 2.1 with NameNode HA, then Express Upgrades 2.1->2.3.0.0->2.3.2.0 and finalize
> HDP without NameNode HA, and then Express Upgrades 2.2->2.3.0.0->2.3.2.0 and downgrade on the last item.
>
> Python unit tests passed.
> ----------------------------------------------------------------------
> Total run:828
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>
Re: Review Request 40370: AMBARI-13913. Express Upgrade: didn't
finalize HDFS, improve robustness for HA
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40370/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 9:59 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
Bugs: AMBARI-13913
https://issues.apache.org/jira/browse/AMBARI-13913
Repository: ambari
Description
-------
For Express Upgrade,
1. We started the NameNodes with "-rollingUpgrade started" but were calling the wrong finalize command, "-finalizeUpgrade" instead of "-rollingUpgrade finalize".
2. In HA, if safemode was already on, then the prepare step would fail since the grep command reported an error.
3. In HA, we now check both NameNodes to come out of safemode. Before, this would only run on the active one.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 1fada76
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py f8a327f
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml efc3753
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml fa69e72
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 6282fdc
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 798c895
Diff: https://reviews.apache.org/r/40370/diff/
Testing (updated)
-------
Tested this during Express Upgrade.
HDP 2.1 with NameNode HA, then Express Upgrades 2.1->2.3.0.0->2.3.2.0 and finalize
HDP without NameNode HA, and then Express Upgrades 2.2->2.3.0.0->2.3.2.0 and downgrade on the last item.
Python unit tests passed.
----------------------------------------------------------------------
Total run:828
Total errors:0
Total failures:0
OK
Thanks,
Alejandro Fernandez
Re: Review Request 40370: AMBARI-13913. Express Upgrade: didn't
finalize HDFS, improve robustness for HA
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40370/#review106739
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py
<https://reviews.apache.org/r/40370/#comment165494>
This was the primary bug that prevented multiple EUs from working because we didn't finalize correctly since NameNode is always started with "-rollingUpgrade started"
ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml (line 376)
<https://reviews.apache.org/r/40370/#comment165495>
Wait for Safemode on all hosts, not just the active one.
- Alejandro Fernandez
On Nov. 16, 2015, 9:51 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40370/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 9:51 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, and Swapan Shridhar.
>
>
> Bugs: AMBARI-13913
> https://issues.apache.org/jira/browse/AMBARI-13913
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For Express Upgrade,
>
> 1. We started the NameNodes with "-rollingUpgrade started" but were calling the wrong finalize command, "-finalizeUpgrade" instead of "-rollingUpgrade finalize".
> 2. In HA, if safemode was already on, then the prepare step would fail since the grep command reported an error.
> 3. In HA, we now check both NameNodes to come out of safemode. Before, this would only run on the active one.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 1fada76
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode_upgrade.py f8a327f
> ambari-server/src/main/resources/stacks/HDP/2.1/upgrades/nonrolling-upgrade-2.3.xml efc3753
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml fa69e72
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml 6282fdc
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 798c895
>
> Diff: https://reviews.apache.org/r/40370/diff/
>
>
> Testing
> -------
>
> Tested this during Express Upgrade.
> HDP 2.1->2.3.0.0->2.3.2.0 and finalize
> HDP 2.2->2.3.0.0->2.3.2.0 and downgrade on the last item.
>
> Python unit tests passed.
> ----------------------------------------------------------------------
> Total run:828
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Alejandro Fernandez
>
>