[jira] [Commented] (ZOOKEEPER-1810) Add version to FLE notifications for trunk

["Alexander Shraer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815484#comment-13815484 ] 

Alexander Shraer commented on ZOOKEEPER-1810:
---------------------------------------------

W.r.t. zk-107 the change in message format was the additional configuration fiend in notifications, which 
is assumed to be at the end. Then there are the new backwardCompatibility flag

                        // ZK-107 sends the configuration info in every message.
                        // So messages are 36 bytes + size of configuration info 
                        // (variable length, shoulld be at the end of the message).
                        boolean backCompatibility36 = (response.buffer.capacity() == 36);

which need to be adjusted because now we may have the version so the size without config may be bigger.

Instead of this flag perhaps we could just check the size to determine that there's a version, and then use the version to see if the message has a config field. Also perhaps it would be cleaner to have a config size field before the config field,so that we get rid of the assumption that config must be last in the message, which makes it more difficult to extend.



> Add version to FLE notifications for trunk
> ------------------------------------------
>
>                 Key: ZOOKEEPER-1810
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Flavio Junqueira
>             Fix For: 3.4.6, 3.5.0
>
>
> The same as ZOOKEEPER-1808 but for trunk.



--
This message was sent by Atlassian JIRA
(v6.1#6144)