You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreschembri <gi...@git.apache.org> on 2015/04/09 16:54:20 UTC
[GitHub] incubator-brooklyn pull request: Catalogitemsummaryfix
GitHub user andreschembri opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/590
Catalogitemsummaryfix
Not sure if this is the correct way to resolve this issue:
- There are some code that is using this POJO that are providing the registeredType and others that do not.
- If the registeredType is present and the constructor does not take it , the mapping would fail, if registeredType is not present and the constructor expects the registeredType the number of arguments would not match.
- I ended up adding a new constructor that takes the registeredType, and leaving the one that does not in place
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreschembri/incubator-brooklyn catalogitemsummaryfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/590.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #590
----
commit 5512dae60c5cf9bc5c1c855e0074d6e4406ca956
Author: Andre <an...@andres-macbook-pro.local>
Date: 2015-04-09T09:51:32Z
added representation of registeredType to CatalogItemSummary
commit 72f040069e566e6a0c6ef0d7440d92c7ea7c8969
Author: Andre <an...@andres-macbook-pro.local>
Date: 2015-04-09T14:47:10Z
Added another constructor for when registeredType is not present
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Catalogitemsummaryfix
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/590#issuecomment-91353390
as noted in #588 this might be fixed a better way in #585 (not caring about `registeredType` which is mostly an internal detail anyway, which hopefully we can get rid of in time...)
if not, can you include a test case showing the failure which is fixed here so we can better understand?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Catalogitemsummaryfix
Posted by andreschembri <gi...@git.apache.org>.
Github user andreschembri commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/590#issuecomment-91536423
Yep this makes sense to me ! hence I am closing this pull request.
Thanks,
Andre
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Catalogitemsummaryfix
Posted by andreschembri <gi...@git.apache.org>.
Github user andreschembri closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/590
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---