You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/16 15:03:51 UTC
[GitHub] [fineract] xurror opened a new pull request #772: FINERACT-881
xurror opened a new pull request #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772
Remove all hard-coded default passwords
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #772:
FINERACT-881
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772#discussion_r410521656
##########
File path: kubernetes/fineract-server-deployment.yml
##########
@@ -59,7 +60,27 @@ spec:
image: apache/fineract:latest
env:
- name: JAVA_OPTS
Review comment:
@xurror remove the `JAVA_OPTS` completely, see https://issues.apache.org/jira/browse/FINERACT-900 for why
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #772: FINERACT-881
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772#issuecomment-616095824
_"I'm Lovin' this PR!"_ © ℗ ® ™
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #772: FINERACT-881
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #772: FINERACT-881
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772#issuecomment-615402486
Following #764 and #761 this will pass the build (or not at least not fail because of integration tests) if you rebase this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on issue #772: FINERACT-881
Posted by GitBox <gi...@apache.org>.
vorburger commented on issue #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772#issuecomment-616095995
PS FTR I haven't actually pulled and myself locally re-verified (I did the original), but I'm sure you have tested this yourself on `minikube` while you made these changes, so I'll merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] xurror commented on issue #772: FINERACT-881
Posted by GitBox <gi...@apache.org>.
xurror commented on issue #772: FINERACT-881
URL: https://github.com/apache/fineract/pull/772#issuecomment-616085561
@vorburger, think this is good to go now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services