You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2019/12/23 23:12:00 UTC
[jira] [Commented] (PHOENIX-5620) Phoenix-client embedded do not
shade properly slf4j classes
[ https://issues.apache.org/jira/browse/PHOENIX-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17002532#comment-17002532 ]
Hadoop QA commented on PHOENIX-5620:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12989401/PHOENIX-5620.4.x-HBase-1.4.v1.patch
against 4.x-HBase-1.4 branch at commit 25cc0764bc7c69511df61e777f851b963f4798fb.
ATTACHMENT ID: 12989401
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:green}+0 tests included{color}. The patch appears to be a documentation, build,
or dev patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3217//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3217//console
This message is automatically generated.
> Phoenix-client embedded do not shade properly slf4j classes
> -----------------------------------------------------------
>
> Key: PHOENIX-5620
> URL: https://issues.apache.org/jira/browse/PHOENIX-5620
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1
> Reporter: Grzegorz Kokosinski
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-5620.4.x-HBase-1.4.v1.patch
>
>
> Phoenix-client should either shade slf4j or require slf4j dependency. Now projects that are using slf4j internally conflicts with phoenix-client embeded
> $ unzip -l ~/.m2/repository/org/apache/phoenix/phoenix-client/4.14.1-HBase-1.4/phoenix-client-4.14.1-HBase-1.4-embedded.jar | grep slf4j
> 0 04-12-2019 13:18 org/slf4j/
> 0 04-12-2019 13:18 org/slf4j/helpers/
> 3366 04-12-2019 13:18 org/slf4j/helpers/BasicMarker.class
> 1427 04-12-2019 13:18 org/slf4j/helpers/BasicMarkerFactory.class
> 2660 04-12-2019 13:18 org/slf4j/helpers/BasicMDCAdapter.class
> 1521 04-12-2019 13:18 org/slf4j/helpers/FormattingTuple.class
> 4704 04-12-2019 13:18 org/slf4j/helpers/MarkerIgnoringBase.class
> 6607 04-12-2019 13:18 org/slf4j/helpers/MessageFormatter.class
> 823 04-12-2019 13:18 org/slf4j/helpers/NamedLoggerBase.class
> 3267 04-12-2019 13:18 org/slf4j/helpers/NOPLogger.class
> 584 04-12-2019 13:18 org/slf4j/helpers/NOPLoggerFactory.class
> 1005 04-12-2019 13:18 org/slf4j/helpers/NOPMDCAdapter.class
> 1047 04-12-2019 13:18 org/slf4j/helpers/SubstituteLoggerFactory.class
> 931 04-12-2019 13:18 org/slf4j/helpers/Util.class
> 180 04-12-2019 13:18 org/slf4j/ILoggerFactory.class
> 272 04-12-2019 13:18 org/slf4j/IMarkerFactory.class
> 1375 04-12-2019 13:18 org/slf4j/Logger.class
> 7940 04-12-2019 13:18 org/slf4j/LoggerFactory.class
> 601 04-12-2019 13:18 org/slf4j/Marker.class
> 1325 04-12-2019 13:18 org/slf4j/MarkerFactory.class
> 2807 04-12-2019 13:18 org/slf4j/MDC.class
> 0 04-12-2019 13:18 org/slf4j/spi/
> 455 04-12-2019 13:18 org/slf4j/spi/LocationAwareLogger.class
> 249 04-12-2019 13:18 org/slf4j/spi/LoggerFactoryBinder.class
> 249 04-12-2019 13:18 org/slf4j/spi/MarkerFactoryBinder.class
> 384 04-12-2019 13:18 org/slf4j/spi/MDCAdapter.class
> 0 04-12-2019 13:18 META-INF/maven/org.slf4j/
> 0 04-12-2019 13:18 META-INF/maven/org.slf4j/slf4j-api/
> 2689 04-12-2019 13:18 META-INF/maven/org.slf4j/slf4j-api/pom.xml
> 108 04-12-2019 13:18 META-INF/maven/org.slf4j/slf4j-api/pom.properties
> Maven complains:
> [WARNING] Found duplicate and different classes in [org.apache.phoenix:phoenix-client:4.14.1-HBase-1.4:jar:embedded, org.slf4j:slf4j-api:1.7.28]:
> [WARNING] org.slf4j.ILoggerFactory
> [WARNING] org.slf4j.IMarkerFactory
> [WARNING] org.slf4j.Logger
> [WARNING] org.slf4j.LoggerFactory
> [WARNING] org.slf4j.MDC
> [WARNING] org.slf4j.Marker
> [WARNING] org.slf4j.MarkerFactory
> [WARNING] org.slf4j.helpers.BasicMDCAdapter
> [WARNING] org.slf4j.helpers.BasicMarker
> [WARNING] org.slf4j.helpers.BasicMarkerFactory
> [WARNING] org.slf4j.helpers.FormattingTuple
> [WARNING] org.slf4j.helpers.MarkerIgnoringBase
> [WARNING] org.slf4j.helpers.MessageFormatter
> [WARNING] org.slf4j.helpers.NOPLogger
> [WARNING] org.slf4j.helpers.NOPLoggerFactory
> [WARNING] org.slf4j.helpers.NOPMDCAdapter
> [WARNING] org.slf4j.helpers.NamedLoggerBase
> [WARNING] org.slf4j.helpers.SubstituteLoggerFactory
> [WARNING] org.slf4j.helpers.Util
> [WARNING] org.slf4j.spi.LocationAwareLogger
> [WARNING] org.slf4j.spi.LoggerFactoryBinder
> [WARNING] org.slf4j.spi.MDCAdapter
> [WARNING] org.slf4j.spi.MarkerFactoryBinder
--
This message was sent by Atlassian Jira
(v8.3.4#803005)