You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/05/27 02:28:52 UTC

[GitHub] [arrow] kou commented on a diff in pull request #35792: GH-20047: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on Windows

kou commented on code in PR #35792:
URL: https://github.com/apache/arrow/pull/35792#discussion_r1207595461


##########
matlab/CMakeLists.txt:
##########
@@ -542,6 +542,23 @@ if(UNIX
   endif()
 endif()
 
+if(WIN32)

Review Comment:
   It seems that we have similar code for `Apple`.
   Can we unify them by using `CMAKE_SHARED_LIBRARY_PATH` variable?
   https://cmake.org/cmake/help/latest/variable/CMAKE_SHARED_LIBRARY_SUFFIX.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org