You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Paul Lindner (JIRA)" <ji...@apache.org> on 2008/07/30 17:47:31 UTC
[jira] Created: (SHINDIG-484) DefaultGuiceModule should validate
required properties
DefaultGuiceModule should validate required properties
------------------------------------------------------
Key: SHINDIG-484
URL: https://issues.apache.org/jira/browse/SHINDIG-484
Project: Shindig
Issue Type: Improvement
Reporter: Paul Lindner
Before we call
Names.bindProperties(this.binder(), properties);
we should do basic validation of the parameters we're injecting. Currently server startup or servlet init will croak
with cryptic error messages if the appropriate parameters are not specified.
For example I spent a few hours with this error:
SEVERE: Allocate exception for servlet xml-to-html
com.google.inject.ConfigurationException: Error at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.setGadgetRenderer(GadgetRenderingServlet.java:38) Binding to com.google.inject.Provider<org.apache.shindig.gadgets.servlet.GadgetRenderingTask> not found. No bindings to that type were found.
And this was actually caused by a missing String binding for "features.default" for GadgetFeatureRegistry
public GadgetFeatureRegistry(@Named("features.default") String featureFiles,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-484) DefaultGuiceModule should validate
required properties
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618438#action_12618438 ]
Kevin Brown commented on SHINDIG-484:
-------------------------------------
That would require that the guice module be aware of every single possible value in the properties files and how to validate them. That just doesn't scale.
> DefaultGuiceModule should validate required properties
> ------------------------------------------------------
>
> Key: SHINDIG-484
> URL: https://issues.apache.org/jira/browse/SHINDIG-484
> Project: Shindig
> Issue Type: Improvement
> Reporter: Paul Lindner
>
> Before we call
> Names.bindProperties(this.binder(), properties);
> we should do basic validation of the parameters we're injecting. Currently server startup or servlet init will croak
> with cryptic error messages if the appropriate parameters are not specified.
> For example I spent a few hours with this error:
> SEVERE: Allocate exception for servlet xml-to-html
> com.google.inject.ConfigurationException: Error at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.setGadgetRenderer(GadgetRenderingServlet.java:38) Binding to com.google.inject.Provider<org.apache.shindig.gadgets.servlet.GadgetRenderingTask> not found. No bindings to that type were found.
> And this was actually caused by a missing String binding for "features.default" for GadgetFeatureRegistry
> public GadgetFeatureRegistry(@Named("features.default") String featureFiles,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-484) DefaultGuiceModule should validate
required properties
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618441#action_12618441 ]
Paul Lindner commented on SHINDIG-484:
--------------------------------------
Well, we need to do something about this. The current Guice error reporting is sub-par and this will make it harder to integrate.
Me, I just want my 4 hours of tracing through Guice Code back... :)
> DefaultGuiceModule should validate required properties
> ------------------------------------------------------
>
> Key: SHINDIG-484
> URL: https://issues.apache.org/jira/browse/SHINDIG-484
> Project: Shindig
> Issue Type: Improvement
> Reporter: Paul Lindner
>
> Before we call
> Names.bindProperties(this.binder(), properties);
> we should do basic validation of the parameters we're injecting. Currently server startup or servlet init will croak
> with cryptic error messages if the appropriate parameters are not specified.
> For example I spent a few hours with this error:
> SEVERE: Allocate exception for servlet xml-to-html
> com.google.inject.ConfigurationException: Error at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.setGadgetRenderer(GadgetRenderingServlet.java:38) Binding to com.google.inject.Provider<org.apache.shindig.gadgets.servlet.GadgetRenderingTask> not found. No bindings to that type were found.
> And this was actually caused by a missing String binding for "features.default" for GadgetFeatureRegistry
> public GadgetFeatureRegistry(@Named("features.default") String featureFiles,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-484) DefaultGuiceModule should validate
required properties
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner updated SHINDIG-484:
---------------------------------
Component/s: Common Components (Java)
> DefaultGuiceModule should validate required properties
> ------------------------------------------------------
>
> Key: SHINDIG-484
> URL: https://issues.apache.org/jira/browse/SHINDIG-484
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Paul Lindner
>
> Before we call
> Names.bindProperties(this.binder(), properties);
> we should do basic validation of the parameters we're injecting. Currently server startup or servlet init will croak
> with cryptic error messages if the appropriate parameters are not specified.
> For example I spent a few hours with this error:
> SEVERE: Allocate exception for servlet xml-to-html
> com.google.inject.ConfigurationException: Error at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.setGadgetRenderer(GadgetRenderingServlet.java:38) Binding to com.google.inject.Provider<org.apache.shindig.gadgets.servlet.GadgetRenderingTask> not found. No bindings to that type were found.
> And this was actually caused by a missing String binding for "features.default" for GadgetFeatureRegistry
> public GadgetFeatureRegistry(@Named("features.default") String featureFiles,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-484) DefaultGuiceModule should validate
required properties
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-484.
--------------------------------
Resolution: Won't Fix
ah well...
> DefaultGuiceModule should validate required properties
> ------------------------------------------------------
>
> Key: SHINDIG-484
> URL: https://issues.apache.org/jira/browse/SHINDIG-484
> Project: Shindig
> Issue Type: Improvement
> Components: Common Components (Java)
> Reporter: Paul Lindner
>
> Before we call
> Names.bindProperties(this.binder(), properties);
> we should do basic validation of the parameters we're injecting. Currently server startup or servlet init will croak
> with cryptic error messages if the appropriate parameters are not specified.
> For example I spent a few hours with this error:
> SEVERE: Allocate exception for servlet xml-to-html
> com.google.inject.ConfigurationException: Error at org.apache.shindig.gadgets.servlet.GadgetRenderingServlet.setGadgetRenderer(GadgetRenderingServlet.java:38) Binding to com.google.inject.Provider<org.apache.shindig.gadgets.servlet.GadgetRenderingTask> not found. No bindings to that type were found.
> And this was actually caused by a missing String binding for "features.default" for GadgetFeatureRegistry
> public GadgetFeatureRegistry(@Named("features.default") String featureFiles,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.