You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GJL <gi...@git.apache.org> on 2018/02/27 16:16:44 UTC

[GitHub] flink pull request #5591: [FLINK-8787][flip6] Deploying FLIP-6 YARN session ...

GitHub user GJL opened a pull request:

    https://github.com/apache/flink/pull/5591

    [FLINK-8787][flip6] Deploying FLIP-6 YARN session with HA fails

    ## What is the purpose of the change
    
    *Do not copy `flinkConfiguration` in `AbstractYarnClusterDescriptor`. There is code that relies on side effects on the configuration object. This is a quick and dirty solution. In future, the descriptor should be made immutable: [FLINK-8799](https://issues.apache.org/jira/browse/FLINK-8799)*
    
    cc: @tillrohrmann 
    
    ## Brief change log
    
      - *Do not copy `flinkConfiguration` in `AbstractYarnClusterDescriptor`*
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *Manually deployed Flink cluster on YARN with HA enabled.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/GJL/flink FLINK-8787-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5591
    
----
commit 012f656705466cea4ba2e037f7e52f46c0a1bf9f
Author: gyao <ga...@...>
Date:   2018-02-27T15:58:53Z

    [FLINK-8787][flip6] Do not copy flinkConfiguration in AbstractYarnClusterDescriptor

----


---

[GitHub] flink pull request #5591: [FLINK-8787][flip6] Deploying FLIP-6 YARN session ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5591


---