You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2016/01/22 23:21:13 UTC
[VOTE] Release Apache Tomcat 8.0.31
The proposed Apache Tomcat 8.0.31 release is now available for voting.
The main changes since 8.0.30 are:
- Restore the default for mapperContextRootRedirectEnabled to true
- Update the packaged version of the Tomcat Native Library to 1.2.4
to pick up the Windows binaries that are based on OpenSSL 1.0.2e
- Expand session attribute filtering on load/unload to all managers
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1060/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
The proposed 8.0.31 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.0.31
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Felix Schumacher <fe...@internetallee.de>.
Am 22.01.2016 um 23:21 schrieb Mark Thomas:
> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>
> The main changes since 8.0.30 are:
>
> - Restore the default for mapperContextRootRedirectEnabled to true
>
> - Update the packaged version of the Tomcat Native Library to 1.2.4
> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>
> - Expand session attribute filtering on load/unload to all managers
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>
> The proposed 8.0.31 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.0.31
Tested on ubuntu 14.04 with openjdk 1.7.0_91 x64.
openssl tests failed as expected, since ubuntu ships with 1.0.1f.
Regards,
Felix
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Martin Grigorov <mg...@apache.org>.
On Fri, Jan 22, 2016 at 11:21 PM, Mark Thomas <ma...@apache.org> wrote:
> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>
> The main changes since 8.0.30 are:
>
> - Restore the default for mapperContextRootRedirectEnabled to true
>
> - Update the packaged version of the Tomcat Native Library to 1.2.4
> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>
> - Expand session attribute filtering on load/unload to all managers
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>
> The proposed 8.0.31 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.31
>
Tested my main application and Apache Wicket WebSocket integration (JSR356).
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Keiichi Fujino <kf...@apache.org>.
2016-01-25 15:57 GMT+09:00 Keiichi Fujino <kf...@apache.org>:
>
>
> 2016-01-23 7:21 GMT+09:00 Mark Thomas <ma...@apache.org>:
>
>> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>>
>> The main changes since 8.0.30 are:
>>
>> - Restore the default for mapperContextRootRedirectEnabled to true
>>
>> - Update the packaged version of the Tomcat Native Library to 1.2.4
>> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>>
>> - Expand session attribute filtering on load/unload to all managers
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>>
>> The proposed 8.0.31 release is:
>> [ ] Broken - do not release
>> [ ] Stable - go ahead and release as 8.0.31
>>
>>
> -0: see r1726576
>
> I think Cluster manager cannot start if sessionAttributeNameFilter and
> sessionAttributeValueClassNameFilter are not set.
> Since the cluster components may not be a showstopper, I voted -0.
>
>
Before r1726576.
if sessionAttributeNameFilter/sessionAttributeValueClassNameFilter set to
"",
the sessionAttributeXXXXXPattern = Pattern.compile("") is invoked.
The sessionAttributeXXXXXPattern should be null.
The code of Pattern.compile("") is illegal.
Therefore, there is a problem in a non-clustered environment.
>
>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>> --
>> Keiichi.Fujino
>> <de...@tomcat.apache.org>
>
> <de...@tomcat.apache.org>
>
--
Keiichi.Fujino
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Keiichi Fujino <kf...@apache.org>.
2016-01-23 7:21 GMT+09:00 Mark Thomas <ma...@apache.org>:
> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>
> The main changes since 8.0.30 are:
>
> - Restore the default for mapperContextRootRedirectEnabled to true
>
> - Update the packaged version of the Tomcat Native Library to 1.2.4
> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>
> - Expand session attribute filtering on load/unload to all managers
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>
> The proposed 8.0.31 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.31
>
>
-0: see r1726576
I think Cluster manager cannot start if sessionAttributeNameFilter and
sessionAttributeValueClassNameFilter are not set.
Since the cluster components may not be a showstopper, I voted -0.
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
> --
> Keiichi.Fujino
> <de...@tomcat.apache.org>
<de...@tomcat.apache.org>
Re: [VOTE][CANCELLED] Release Apache Tomcat 8.0.31
Posted by Mark Thomas <ma...@apache.org>.
Given that:
- the default clustering config is broken in 8.0.31
- OpenSSL has a security release due on the 28th
I am cancelling the 8.0.31 release. I think it makes sense to wait for
the OpenSSl announcement before tagging 8.0.32 in case a new
tomcat-native release is required.
Any further testing with 8.0.31 will be appreciated even though the vote
is cancelled.
Thanks,
Mark
On 22/01/2016 22:21, Mark Thomas wrote:
> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>
> The main changes since 8.0.30 are:
>
> - Restore the default for mapperContextRootRedirectEnabled to true
>
> - Update the packaged version of the Tomcat Native Library to 1.2.4
> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>
> - Expand session attribute filtering on load/unload to all managers
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>
> The proposed 8.0.31 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.31
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Mark Thomas <ma...@apache.org>.
On 22/01/2016 22:21, Mark Thomas wrote:
> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>
> The main changes since 8.0.30 are:
>
> - Restore the default for mapperContextRootRedirectEnabled to true
>
> - Update the packaged version of the Tomcat Native Library to 1.2.4
> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>
> - Expand session attribute filtering on load/unload to all managers
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>
> The proposed 8.0.31 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.31
Unit tests for BIO, NIO, NIO2 and APR all pass on Windows, Linux and OSX.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Keiichi Fujino <kf...@apache.org>.
2016-01-25 15:20 GMT+09:00 Tatsuya Bessho <t....@gmail.com>:
> 2016-01-23 7:21 GMT+09:00 Mark Thomas <ma...@apache.org>:
> > The proposed Apache Tomcat 8.0.31 release is now available for voting.
> >
> > The main changes since 8.0.30 are:
> >
> > - Restore the default for mapperContextRootRedirectEnabled to true
> >
> > - Update the packaged version of the Tomcat Native Library to 1.2.4
> > to pick up the Windows binaries that are based on OpenSSL 1.0.2e
> >
> > - Expand session attribute filtering on load/unload to all managers
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> > The svn tag is:
> > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
> >
> > The proposed 8.0.31 release is:
> > [ ] Broken - do not release
> > [ ] Stable - go ahead and release as 8.0.31
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
>
> Hi.
>
> Tested enable DeltaManager.
> Occured following NPE.
> ------------------------------
> 25-Jan-2016 09:41:42.279 SEVERE [localhost-startStop-1]
> org.apache.catalina.ha.tcp.SimpleTcpCluster.createManager Unable to
> clone cluster manager, defaulting to
> org.apache.catalina.ha.session.DeltaManager
> java.lang.NullPointerException
> at java.util.regex.Pattern.<init>(Pattern.java:1350)
> at java.util.regex.Pattern.compile(Pattern.java:1028)
> at
> org.apache.catalina.session.ManagerBase.setSessionAttributeNameFilter(ManagerBase.java:267)
> at
> org.apache.catalina.ha.session.ClusterManagerBase.clone(ClusterManagerBase.java:193)
> at
> org.apache.catalina.ha.session.DeltaManager.cloneFromTemplate(DeltaManager.java:1436)
> at
> org.apache.catalina.ha.tcp.SimpleTcpCluster.createManager(SimpleTcpCluster.java:407)
> at
> org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5180)
> at
> org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
> at
> org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
> at
> org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
> at
> org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
> at
> org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:585)
> at
> org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1794)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> ------------------------------
>
> I made pache.
> ------------------------------
> Index: java/org/apache/catalina/session/ManagerBase.java
> ===================================================================
> --- java/org/apache/catalina/session/ManagerBase.java (revision 1726569)
> +++ java/org/apache/catalina/session/ManagerBase.java (working copy)
> @@ -263,8 +263,9 @@
> public void setSessionAttributeNameFilter(String
> sessionAttributeNameFilter) {
> if (sessionAttributeNameFilter == null ||
> sessionAttributeNameFilter.length() == 0) {
> sessionAttributeNamePattern = null;
> + } else {
> + sessionAttributeNamePattern =
> Pattern.compile(sessionAttributeNameFilter);
> }
> - sessionAttributeNamePattern =
> Pattern.compile(sessionAttributeNameFilter);
> }
>
>
>
Thanks Tatsuya.
Fixed at r1726576.
>
> ------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
> --
> Keiichi.Fujino
> <de...@tomcat.apache.org>
> <de...@tomcat.apache.org>
>
Re: [VOTE] Release Apache Tomcat 8.0.31
Posted by Tatsuya Bessho <t....@gmail.com>.
2016-01-23 7:21 GMT+09:00 Mark Thomas <ma...@apache.org>:
> The proposed Apache Tomcat 8.0.31 release is now available for voting.
>
> The main changes since 8.0.30 are:
>
> - Restore the default for mapperContextRootRedirectEnabled to true
>
> - Update the packaged version of the Tomcat Native Library to 1.2.4
> to pick up the Windows binaries that are based on OpenSSL 1.0.2e
>
> - Expand session attribute filtering on load/unload to all managers
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.31/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1060/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_31/
>
> The proposed 8.0.31 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.31
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
Hi.
Tested enable DeltaManager.
Occured following NPE.
------------------------------
25-Jan-2016 09:41:42.279 SEVERE [localhost-startStop-1]
org.apache.catalina.ha.tcp.SimpleTcpCluster.createManager Unable to
clone cluster manager, defaulting to
org.apache.catalina.ha.session.DeltaManager
java.lang.NullPointerException
at java.util.regex.Pattern.<init>(Pattern.java:1350)
at java.util.regex.Pattern.compile(Pattern.java:1028)
at org.apache.catalina.session.ManagerBase.setSessionAttributeNameFilter(ManagerBase.java:267)
at org.apache.catalina.ha.session.ClusterManagerBase.clone(ClusterManagerBase.java:193)
at org.apache.catalina.ha.session.DeltaManager.cloneFromTemplate(DeltaManager.java:1436)
at org.apache.catalina.ha.tcp.SimpleTcpCluster.createManager(SimpleTcpCluster.java:407)
at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5180)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)
at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:585)
at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1794)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
------------------------------
I made pache.
------------------------------
Index: java/org/apache/catalina/session/ManagerBase.java
===================================================================
--- java/org/apache/catalina/session/ManagerBase.java (revision 1726569)
+++ java/org/apache/catalina/session/ManagerBase.java (working copy)
@@ -263,8 +263,9 @@
public void setSessionAttributeNameFilter(String
sessionAttributeNameFilter) {
if (sessionAttributeNameFilter == null ||
sessionAttributeNameFilter.length() == 0) {
sessionAttributeNamePattern = null;
+ } else {
+ sessionAttributeNamePattern =
Pattern.compile(sessionAttributeNameFilter);
}
- sessionAttributeNamePattern =
Pattern.compile(sessionAttributeNameFilter);
}
------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org