You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by sh...@apache.org on 2023/05/23 10:30:59 UTC
[kafka] 01/02: Fix log DateTime format unit test (#13441)
This is an automated email from the ASF dual-hosted git repository.
showuon pushed a commit to branch 3.4
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit f683178805caad6eca9d232503fe4b9f533f76ff
Author: egyedt <81...@users.noreply.github.com>
AuthorDate: Mon Mar 27 10:48:47 2023 +0200
Fix log DateTime format unit test (#13441)
Reviewers: Viktor Somogyi-Vass <vi...@gmail.com>
---
.../src/test/java/org/apache/kafka/common/utils/UtilsTest.java | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java b/clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
index d10fd37a71b..c75ad9d5e4f 100755
--- a/clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
+++ b/clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
@@ -34,7 +34,6 @@ import java.nio.channels.FileChannel;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.StandardOpenOption;
-import java.time.Instant;
import java.time.LocalDateTime;
import java.time.ZoneId;
import java.time.ZoneOffset;
@@ -915,14 +914,13 @@ public class UtilsTest {
@Test
public void testToLogDateTimeFormat() {
+ final LocalDateTime timestampWithMilliSeconds = LocalDateTime.of(2020, 11, 9, 12, 34, 5, 123000000);
+ final LocalDateTime timestampWithSeconds = LocalDateTime.of(2020, 11, 9, 12, 34, 5);
+
DateTimeFormatter offsetFormatter = DateTimeFormatter.ofPattern("XXX");
- ZoneOffset offset = ZoneId.systemDefault().getRules().getOffset(Instant.now());
-
+ ZoneOffset offset = ZoneId.systemDefault().getRules().getOffset(timestampWithSeconds);
String requiredOffsetFormat = offsetFormatter.format(offset);
- final LocalDateTime timestampWithMilliSeconds = LocalDateTime.of(2020, 11, 9, 12, 34, 5, 123000000);
- final LocalDateTime timestampWithSeconds = LocalDateTime.of(2020, 11, 9, 12, 34, 5);
-
assertEquals(String.format("2020-11-09 12:34:05,123 %s", requiredOffsetFormat), Utils.toLogDateTimeFormat(timestampWithMilliSeconds.atZone(ZoneId.systemDefault()).toInstant().toEpochMilli()));
assertEquals(String.format("2020-11-09 12:34:05,000 %s", requiredOffsetFormat), Utils.toLogDateTimeFormat(timestampWithSeconds.atZone(ZoneId.systemDefault()).toInstant().toEpochMilli()));
}