Typo in AbstractRenderer :: renderBlockViewPort

[Paul Vinkenoog <pa...@vinkenoog.nl>]

Hi all,

In fop/render/AbstractRenderer.java, lines 453-462:

  protected void renderBlockViewport(BlockViewport bv, List children) {
      // clip and position viewport if necessary
      if (bv.getPositioning() == Block.ABSOLUTE) {
          // save positions
          int saveIP = currentIPPosition;
          int saveBP = currentBPPosition;

          Rectangle2D clippingRect = null;
          if (bv.getClip()) {
              clippingRect = new Rectangle(saveIP, saveBP, bv.getIPD(), bv.getIPD());

I suppose the second call to getIPD() should be getBPD(), unless you
want to force the clipping rect to be square.

At first I wanted to report this through Bugzilla, but the Getting
Help page stipulated that it should be raised at the user list first,
so here it is.


Kind regards,
Paul Vinkenoog

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-users-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-users-help@xmlgraphics.apache.org

Re: Typo in AbstractRenderer :: renderBlockViewPort

[Andreas L Delmelle <a_...@pandora.be>]

On Mar 9, 2007, at 16:29, Paul Vinkenoog wrote:

Hi Paul,

Just a little FYI: I (finally) got around to committing your  
suggested correction to the trunk.

>
>> Ultimately, the quality of FOP depends greatly upon users like
>> yourself, who are not afraid to take a stroll through the code,
>
> The reason I looked at the code at all was that I wanted to
> re-implement the full internal link behaviour (landing on the exact
> spot, that is). I've got it working now, need to iron out a few
> wrinkles and then I'll bring it up on fop-dev. I hope it's usable for
> the project too.

Thanks in advance! We're awaiting your patch proposal. ;)


Cheers,

Andreas

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-users-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-users-help@xmlgraphics.apache.org

Re: Typo in AbstractRenderer :: renderBlockViewPort

[Paul Vinkenoog <pa...@vinkenoog.nl>]

Hello Andreas,

>> At first I wanted to report this through Bugzilla, but the Getting
>> Help page stipulated that it should be raised at the user list first,
>> so here it is.

> Well, in fact this is slightly off-topic here, and belongs more on
> fop-dev@.

That's what I figured too, but being a relative newcomer I decided to
follow the published guidelines to the letter :-)

> Ultimately, the quality of FOP depends greatly upon users like
> yourself, who are not afraid to take a stroll through the code,

The reason I looked at the code at all was that I wanted to
re-implement the full internal link behaviour (landing on the exact
spot, that is). I've got it working now, need to iron out a few
wrinkles and then I'll bring it up on fop-dev. I hope it's usable for
the project too.


Kind regards,
Paul Vinkenoog

---------------------------------------------------------------------
To unsubscribe, e-mail: fop-users-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-users-help@xmlgraphics.apache.org

Re: Typo in AbstractRenderer :: renderBlockViewPort

[Andreas L Delmelle <a_...@pandora.be>]

On Mar 9, 2007, at 15:43, Paul Vinkenoog wrote:

Hi Paul,

> In fop/render/AbstractRenderer.java, lines 453-462:
> <snip />

> I suppose the second call to getIPD() should be getBPD(), unless you
> want to force the clipping rect to be square.

Looks like a typo indeed. I'll commit the change to the trunk shortly.

> At first I wanted to report this through Bugzilla, but the Getting
> Help page stipulated that it should be raised at the user list first,
> so here it is.

Well, in fact this is slightly off-topic here, and belongs more on  
fop-dev@.
Bugzilla would not make it necessary for you to subscribe to that  
list to reach us there (only have to create a Bugzilla account)

But in any case, thanks for the vigilant eye!
If you encounter any more of these, please do report them.  
Ultimately, the quality of FOP depends greatly upon users like  
yourself, who are not afraid to take a stroll through the code, and  
don't assume that everything they see there is correct.


Cheers,

Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: fop-users-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-users-help@xmlgraphics.apache.org